[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #5908: [TE] Remove deprecated classes under /detection/algorithm

[GitBox <gi...@apache.org>]

jihaozh commented on a change in pull request #5908:
URL: https://github.com/apache/incubator-pinot/pull/5908#discussion_r475999885



##########
File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/DetectionUtils.java
##########
@@ -106,12 +106,12 @@ public static String getSpecClassName(Class<BaseComponent> componentClass) {
    * @param slice metric slice
    * @param df time series with COL_TIME and at least one boolean value series
    * @param seriesName name of the value series
-   * @param endTime end time of this detection window
    * @param monitoringGranularityPeriod the monitoring granularity period
    * @param dataset dataset config for the metric
    * @return list of anomalies
    */
-  public static List<MergedAnomalyResultDTO> makeAnomalies(MetricSlice slice, DataFrame df, String seriesName, long endTime, Period monitoringGranularityPeriod, DatasetConfigDTO dataset) {
+  public static List<MergedAnomalyResultDTO> makeAnomalies(MetricSlice slice, DataFrame df, String seriesName,

Review comment:
       This method is referenced in external code, need to modify that one too. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org