You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gearpump.apache.org by manuzhang <gi...@git.apache.org> on 2017/02/10 00:34:31 UTC

[GitHub] incubator-gearpump pull request #143: [GEARPUMP-103] Support finite stream

GitHub user manuzhang opened a pull request:

    https://github.com/apache/incubator-gearpump/pull/143

    [GEARPUMP-103] Support finite stream

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the commit message is formatted like:
       `[GEARPUMP-<Jira issue #>] Meaningful description of pull request` 
     - [ ] Make sure tests pass via `sbt clean test`.
     - [ ] Make sure old documentation affected by the pull request has been updated and new documentation added for new functionality. 
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/manuzhang/incubator-gearpump finite_stream

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-gearpump/pull/143.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #143
    
----
commit 5714e2b4662d2108b29f4b4ddc33aa517c707cf3
Author: manuzhang <ow...@gmail.com>
Date:   2017-02-09T02:21:11Z

    [GEARPUMP-103] Support finite stream

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-gearpump issue #143: [GEARPUMP-103] Support finite stream

Posted by manuzhang <gi...@git.apache.org>.
Github user manuzhang commented on the issue:

    https://github.com/apache/incubator-gearpump/pull/143
  
    Checking minClock on `Update` instead of `HealthCheck` in ClockService reduces finish time.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-gearpump issue #143: [GEARPUMP-103] Support finite stream

Posted by manuzhang <gi...@git.apache.org>.
Github user manuzhang commented on the issue:

    https://github.com/apache/incubator-gearpump/pull/143
  
    R: @huafengw 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-gearpump issue #143: [GEARPUMP-103] Support finite stream

Posted by huafengw <gi...@git.apache.org>.
Github user huafengw commented on the issue:

    https://github.com/apache/incubator-gearpump/pull/143
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-gearpump pull request #143: [GEARPUMP-103] Support finite stream

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-gearpump/pull/143


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-gearpump pull request #143: [GEARPUMP-103] Support finite stream

Posted by huafengw <gi...@git.apache.org>.
Github user huafengw commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/143#discussion_r100454422
  
    --- Diff: streaming/src/main/scala/org/apache/gearpump/streaming/task/TaskActor.scala ---
    @@ -247,7 +247,11 @@ class TaskActor(
             updateUpstreamMinClock(instant.toEpochMilli)
             minClockReported = false
           }
    -      receiveMessage(watermark.toMessage, sender)
    +
    +      // Instant.MAX marks the end of input stream
    +      if (instant.isBefore(Instant.MAX)) {
    +        receiveMessage(watermark.toMessage, sender)
    +      }
    --- End diff --
    
    Why the Task could not handle Instant.Max?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-gearpump issue #143: [GEARPUMP-103] Support finite stream

Posted by manuzhang <gi...@git.apache.org>.
Github user manuzhang commented on the issue:

    https://github.com/apache/incubator-gearpump/pull/143
  
    It took more than a minute for a simple dsl application to finish. We should improve this in follow-ups.
    
    ![image](https://cloud.githubusercontent.com/assets/1191767/22809863/0f29d180-ef70-11e6-98c5-3abfdfcdfbee.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-gearpump issue #143: [GEARPUMP-103] Support finite stream

Posted by manuzhang <gi...@git.apache.org>.
Github user manuzhang commented on the issue:

    https://github.com/apache/incubator-gearpump/pull/143
  
    Another thing is that when the application finishes the dashboard hangs there instead of going back to the applications page. Or we should allow user to view the history metrics.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---