You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/08/16 06:35:03 UTC

[GitHub] [incubator-yunikorn-core] chia7712 commented on pull request #304: YUNIKORN-799 Fix NPE in application#GetQueueName

chia7712 commented on pull request #304:
URL: https://github.com/apache/incubator-yunikorn-core/pull/304#issuecomment-899260230


   @wilfred-s thanks for this quick feedback.
   
   > This breaks the logging that is in processApplications() as part of the placing of an app in the queue. We explicitly want the queue path for the logging to show where exactly the app is placed. Changing QueueName to contain the full path will break other things.
   
   the logging happens only if `addApplication` succeeds (https://github.com/apache/incubator-yunikorn-core/blob/master/pkg/scheduler/context.go#L466). The `addApplication` (https://github.com/apache/incubator-yunikorn-core/blob/master/pkg/scheduler/partition.go#L366) updates both `queue` and `QueueName` at the same time so `QueueName` always contain the full path when `processApplications` logs it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org