You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by mtunique <gi...@git.apache.org> on 2017/01/10 15:21:03 UTC
[GitHub] flink pull request #3087: [FLINK-4917] Deprecate "CheckpointedAsynchronously...
GitHub user mtunique opened a pull request:
https://github.com/apache/flink/pull/3087
[FLINK-4917] Deprecate "CheckpointedAsynchronously" interface
- [x] General
- The pull request references the related JIRA issue ([FLINK-4917] Deprecate "CheckpointedAsynchronously" interface)
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the JIRA id)
- [x] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mtunique/flink flink-4917
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3087.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3087
----
commit e4ed2142447daf585cdd0c76fadc559429f8ac11
Author: mtunique <oa...@gmail.com>
Date: 2017-01-10T15:05:44Z
[FLINK-4917] Deprecate "CheckpointedAsynchronously" interface
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3087: [FLINK-4917] Deprecate "CheckpointedAsynchronously" inter...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3087
@mtunique I am addressing the `Checkpointed` in a quick followup to this pull request, pretty much copying the docs from `CheckpointedAsynchronously`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3087: [FLINK-4917] Deprecate "CheckpointedAsynchronously" inter...
Posted by mtunique <gi...@git.apache.org>.
Github user mtunique commented on the issue:
https://github.com/apache/flink/pull/3087
Maybe we should open an issue about `Checkpointed` java doc to talk about how to replace the APIs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3087: [FLINK-4917] Deprecate "CheckpointedAsynchronously" inter...
Posted by mtunique <gi...@git.apache.org>.
Github user mtunique commented on the issue:
https://github.com/apache/flink/pull/3087
@greghogan I have add the javadoc about replacement. Maybe `Checkpointed` has the same problem about javadoc. Fix it in this PR or create a new issue on jira?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3087: [FLINK-4917] Deprecate "CheckpointedAsynchronously" inter...
Posted by mtunique <gi...@git.apache.org>.
Github user mtunique commented on the issue:
https://github.com/apache/flink/pull/3087
I am sorry about it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3087: [FLINK-4917] Deprecate "CheckpointedAsynchronously" inter...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3087
Thanks, much better now!
Will merge this for 1.2 and master...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3087: [FLINK-4917] Deprecate "CheckpointedAsynchronously...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3087
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3087: [FLINK-4917] Deprecate "CheckpointedAsynchronously" inter...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3087
Per Fabian's comment from the Jira, we should also document the deprecation in the javadoc with the recommended replacement functionality.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3087: [FLINK-4917] Deprecate "CheckpointedAsynchronously" inter...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3087
I think this needs to also talk about the asynchrony, and the short cut replacement via `ListCheckpointed` etc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---