You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@logging.apache.org by Volkan Yazıcı <vo...@gmail.com> on 2020/06/17 08:29:47 UTC

Review request for LOG4J2-2828

Hello,

I've pushed a fix[1] for LOG4J2-2828[2]. Would somebody mind reviewing
it, please?

Cheers!

[1] https://github.com/apache/logging-log4j2/pull/364
[2] https://issues.apache.org/jira/projects/LOG4J2/issues/LOG4J2-2828

Re: Review request for LOG4J2-2828

Posted by Volkan Yazıcı <vo...@gmail.com>.

Okay, I understand. I've cherry-picked the fix onto release-2.x.

On Wed, Jun 17, 2020 at 5:37 PM Ralph Goers <ra...@dslextreme.com> wrote:
>
> Please remember that when appropriate bug fixes should also be applied to the release-2.x branch (and vice-versa).  I typically try to cherry-pick the commits but that doesn’t always work.
>
> Ralph
>
> > On Jun 17, 2020, at 3:44 AM, Volkan Yazıcı <vo...@gmail.com> wrote:
> >
> > One more "blocker" is down.
> > Changes are merged to master.
> > Thanks to @Remko for the review.
> >
> > On Wed, Jun 17, 2020 at 10:29 AM Volkan Yazıcı <vo...@gmail.com> wrote:
> >>
> >> Hello,
> >>
> >> I've pushed a fix[1] for LOG4J2-2828[2]. Would somebody mind reviewing
> >> it, please?
> >>
> >> Cheers!
> >>
> >> [1] https://github.com/apache/logging-log4j2/pull/364
> >> [2] https://issues.apache.org/jira/projects/LOG4J2/issues/LOG4J2-2828
> >
>
>

Re: Review request for LOG4J2-2828

Posted by Ralph Goers <ra...@dslextreme.com>.

Please remember that when appropriate bug fixes should also be applied to the release-2.x branch (and vice-versa).  I typically try to cherry-pick the commits but that doesn’t always work.

Ralph

> On Jun 17, 2020, at 3:44 AM, Volkan Yazıcı <vo...@gmail.com> wrote:
> 
> One more "blocker" is down.
> Changes are merged to master.
> Thanks to @Remko for the review.
> 
> On Wed, Jun 17, 2020 at 10:29 AM Volkan Yazıcı <vo...@gmail.com> wrote:
>> 
>> Hello,
>> 
>> I've pushed a fix[1] for LOG4J2-2828[2]. Would somebody mind reviewing
>> it, please?
>> 
>> Cheers!
>> 
>> [1] https://github.com/apache/logging-log4j2/pull/364
>> [2] https://issues.apache.org/jira/projects/LOG4J2/issues/LOG4J2-2828
>

Re: Review request for LOG4J2-2828

Posted by Volkan Yazıcı <vo...@gmail.com>.

One more "blocker" is down.
Changes are merged to master.
Thanks to @Remko for the review.

On Wed, Jun 17, 2020 at 10:29 AM Volkan Yazıcı <vo...@gmail.com> wrote:
>
> Hello,
>
> I've pushed a fix[1] for LOG4J2-2828[2]. Would somebody mind reviewing
> it, please?
>
> Cheers!
>
> [1] https://github.com/apache/logging-log4j2/pull/364
> [2] https://issues.apache.org/jira/projects/LOG4J2/issues/LOG4J2-2828