You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Sebastian Wong (JIRA)" <ji...@apache.org> on 2013/11/15 06:09:22 UTC
[jira] [Updated] (YARN-1332) In TestAMRMClient, replace assertTrue
with assertEquals where possible
[ https://issues.apache.org/jira/browse/YARN-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebastian Wong updated YARN-1332:
---------------------------------
Attachment: YARN-1332.patch
Hello,
First time contributor here. I went into TestAMRMClient.java and replaced all the assertTrue(amClient.ask.size() == 0) calls with assertEquals(0, amClient.ask.size()).
Running the unit tests resulted in what I think is the unit tests for TestAMRMClient successfully passing with the output:
Running org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 20.374 sec - in org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
Please let me know if I did anything wrong.
Thanks,
Sebastian
> In TestAMRMClient, replace assertTrue with assertEquals where possible
> ----------------------------------------------------------------------
>
> Key: YARN-1332
> URL: https://issues.apache.org/jira/browse/YARN-1332
> Project: Hadoop YARN
> Issue Type: Improvement
> Affects Versions: 2.2.0
> Reporter: Sandy Ryza
> Priority: Minor
> Labels: newbie
> Attachments: YARN-1332.patch
>
>
> TestAMRMClient uses a lot of "assertTrue(amClient.ask.size() == 0)" where "assertEquals(0, amClient.ask.size())" would make it easier to see why it's failing at a glance.
--
This message was sent by Atlassian JIRA
(v6.1#6144)