You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/04/02 04:35:46 UTC

[GitHub] [incubator-gobblin] autumnust commented on a change in pull request #2947: GOBBLIN-1107: Lazily initialize Helix TaskStateModelFactory in Gobbli…

autumnust commented on a change in pull request #2947: GOBBLIN-1107: Lazily initialize Helix TaskStateModelFactory in Gobbli…
URL: https://github.com/apache/incubator-gobblin/pull/2947#discussion_r402045864
 
 

 ##########
 File path: gobblin-cluster/src/test/java/org/apache/gobblin/cluster/GobblinTaskRunnerTest.java
 ##########
 @@ -156,13 +179,73 @@ public void testConnectHelixManagerWithRetry() {
     //Ensure that connect with retry succeeds
     corruptGobblinTaskRunner.connectHelixManagerWithRetry();
     Assert.assertTrue(true);
+
+    corruptGobblinTaskRunner.disconnectHelixManager();
 
 Review comment:
   Should `corruptGobblinTaskRunner ` be a local variable?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services