You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Dave Brosius <db...@mebigfatguy.com> on 2013/06/19 05:25:33 UTC
Review Request: Remove code that does nothing but allocate a bunch of objects
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11953/
-----------------------------------------------------------
Review request for cloudstack.
Description
-------
remove code that may have been used for something in the past, but now does nothing but allocate memory temporarily.
Diffs
-----
engine/orchestration/src/org/apache/cloudstack/engine/cloud/entity/api/VMEntityManagerImpl.java 38ed7e6
Diff: https://reviews.apache.org/r/11953/diff/
Testing
-------
Thanks,
Dave Brosius
Re: Review Request 11953: Remove code that does nothing but allocate a bunch
of objects
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11953/#review22649
-----------------------------------------------------------
Ship it!
625a9a1 -> master
@Prachi - don't forget to apply it when you Ship it! I've applied this for now.
- Prasanna Santhanam
On June 30, 2013, 5:52 a.m., Dave Brosius wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11953/
> -----------------------------------------------------------
>
> (Updated June 30, 2013, 5:52 a.m.)
>
>
> Review request for cloudstack, Alena Prokharchyk and Prachi Damle.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> remove code that may have been used for something in the past, but now does nothing but allocate memory temporarily.
>
>
> Diffs
> -----
>
> engine/orchestration/src/org/apache/cloudstack/engine/cloud/entity/api/VMEntityManagerImpl.java 38ed7e6
>
> Diff: https://reviews.apache.org/r/11953/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dave Brosius
>
>
Re: Review Request 11953: Remove code that does nothing but allocate a bunch
of objects
Posted by Prachi Damle <pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11953/#review22615
-----------------------------------------------------------
Ship it!
This change looks good, we can remove this part for now.
Some background about this code:
Originaly the design was to pass down the poolId from the reservation via the DeploymentPlan to the DeploymentPlanners to use. However we need some refactoring around this code to be able to pass multiple pool information in case a VM has multiple Volumes. Until then we will let the planners figure out the pools to use for deployment always, so passing the poolId null for now.
- Prachi Damle
On June 30, 2013, 5:52 a.m., Dave Brosius wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11953/
> -----------------------------------------------------------
>
> (Updated June 30, 2013, 5:52 a.m.)
>
>
> Review request for cloudstack, Alena Prokharchyk and Prachi Damle.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> remove code that may have been used for something in the past, but now does nothing but allocate memory temporarily.
>
>
> Diffs
> -----
>
> engine/orchestration/src/org/apache/cloudstack/engine/cloud/entity/api/VMEntityManagerImpl.java 38ed7e6
>
> Diff: https://reviews.apache.org/r/11953/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dave Brosius
>
>
Re: Review Request 11953: Remove code that does nothing but allocate a bunch
of objects
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11953/
-----------------------------------------------------------
(Updated June 30, 2013, 5:52 a.m.)
Review request for cloudstack, Alena Prokharchyk and Prachi Damle.
Changes
-------
including couple reviewers
Repository: cloudstack-git
Description
-------
remove code that may have been used for something in the past, but now does nothing but allocate memory temporarily.
Diffs
-----
engine/orchestration/src/org/apache/cloudstack/engine/cloud/entity/api/VMEntityManagerImpl.java 38ed7e6
Diff: https://reviews.apache.org/r/11953/diff/
Testing
-------
Thanks,
Dave Brosius
Re: Review Request 11953: Remove code that does nothing but allocate a bunch
of objects
Posted by Laszlo Hornyak <la...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11953/#review22566
-----------------------------------------------------------
Looks like the whole point is to calculate the poolId and the DataCenterDeployment constructor does take a poolId argument, but instead a null is passed. Just wondering if the original intention here was to pass the poolId over rather than having null there.
But anyway, the temporary object reservation would not be necessary even then, the code could iterate over the keySet() rather than on its copy.
- Laszlo Hornyak
On June 29, 2013, 2:35 a.m., Dave Brosius wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11953/
> -----------------------------------------------------------
>
> (Updated June 29, 2013, 2:35 a.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> remove code that may have been used for something in the past, but now does nothing but allocate memory temporarily.
>
>
> Diffs
> -----
>
> engine/orchestration/src/org/apache/cloudstack/engine/cloud/entity/api/VMEntityManagerImpl.java 38ed7e6
>
> Diff: https://reviews.apache.org/r/11953/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dave Brosius
>
>
Re: Review Request 11953: Remove code that does nothing but allocate a bunch
of objects
Posted by Dave Brosius <db...@mebigfatguy.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11953/
-----------------------------------------------------------
(Updated June 29, 2013, 2:35 a.m.)
Review request for cloudstack.
Repository: cloudstack-git
Description
-------
remove code that may have been used for something in the past, but now does nothing but allocate memory temporarily.
Diffs
-----
engine/orchestration/src/org/apache/cloudstack/engine/cloud/entity/api/VMEntityManagerImpl.java 38ed7e6
Diff: https://reviews.apache.org/r/11953/diff/
Testing
-------
Thanks,
Dave Brosius