[GitHub] [superset] kasiazjc commented on pull request #21366: fix(explore): disable resize bar when the results area is collapsed

[GitBox <gi...@apache.org>]

kasiazjc commented on PR #21366:
URL: https://github.com/apache/superset/pull/21366#issuecomment-1243671431

   > @stephenLYZ this LGTM. I am wondering if we should close the data panel automatically when it reaches the bottom, as it is in fact the same as closing it. CC @kasiazjc
   > 
   >  Superset.mp4
   
   good call @geido, I think it makes sense! You cannot see anything, so there is no point in it being expanded. 
   
   There is one edge case, where someone may be playing with the drag and drop and out of the blue the section will collapse itself and they will have to manually expand which can be annoying. But I'd still say that we should go with your suggestion, Diego and we'll hear feedback that it doesn't make sense, then we'll revert it. 
   
   cc: @stephenLYZ 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org