You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "Claus Ibsen (JIRA)" <ji...@apache.org> on 2008/06/04 20:55:00 UTC
[jira] Created: (CAMEL-578) JMX Instrumentation -
PerformanceCounter - last processed timestamp
JMX Instrumentation - PerformanceCounter - last processed timestamp
-------------------------------------------------------------------
Key: CAMEL-578
URL: https://issues.apache.org/activemq/browse/CAMEL-578
Project: Apache Camel
Issue Type: Improvement
Components: camel-core
Affects Versions: 1.3.0
Reporter: Claus Ibsen
Priority: Minor
Add a timestamp for the last completed exchange on the Camel JMX PerfformanceCounter.
Its very nice to be able to see this information in the JMX console.
And maybe add a first processed timestamp as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CAMEL-578) JMX Instrumentation -
PerformanceCounter - last processed timestamp
Posted by "Hadrian Zbarcea (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hadrian Zbarcea resolved CAMEL-578.
-----------------------------------
Fix Version/s: 1.4.0
Resolution: Fixed
Excellent. Thanks for the patch William!
> JMX Instrumentation - PerformanceCounter - last processed timestamp
> -------------------------------------------------------------------
>
> Key: CAMEL-578
> URL: https://issues.apache.org/activemq/browse/CAMEL-578
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Claus Ibsen
> Priority: Minor
> Fix For: 1.4.0
>
> Attachments: jconsole.PNG, patch.txt
>
>
> Add a timestamp for the last completed exchange on the Camel JMX PerfformanceCounter.
> Its very nice to be able to see this information in the JMX console.
> And maybe add a first processed timestamp as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-578) JMX Instrumentation -
PerformanceCounter - last processed timestamp
Posted by "William Tam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43279#action_43279 ]
William Tam commented on CAMEL-578:
-----------------------------------
Hi Claus,
Sure. Most users probably more familiar with usec, too. JConsole does not show attribute description which is a bit of a bummer.
> JMX Instrumentation - PerformanceCounter - last processed timestamp
> -------------------------------------------------------------------
>
> Key: CAMEL-578
> URL: https://issues.apache.org/activemq/browse/CAMEL-578
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 1.4.0
>
> Attachments: jconsole.PNG, jconsole_nanosecond.PNG, nanosecnd-patch.txt, patch.txt, undo_nano_patch.txt
>
>
> Add a timestamp for the last completed exchange on the Camel JMX PerfformanceCounter.
> Its very nice to be able to see this information in the JMX console.
> And maybe add a first processed timestamp as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-578) JMX Instrumentation -
PerformanceCounter - last processed timestamp
Posted by "William Tam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
William Tam updated CAMEL-578:
------------------------------
Attachment: nanosecnd-patch.txt
A patch that displays performance counters in nanoseconds.
> JMX Instrumentation - PerformanceCounter - last processed timestamp
> -------------------------------------------------------------------
>
> Key: CAMEL-578
> URL: https://issues.apache.org/activemq/browse/CAMEL-578
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Claus Ibsen
> Priority: Minor
> Fix For: 1.4.0
>
> Attachments: jconsole.PNG, jconsole_nanosecond.PNG, nanosecnd-patch.txt, patch.txt
>
>
> Add a timestamp for the last completed exchange on the Camel JMX PerfformanceCounter.
> Its very nice to be able to see this information in the JMX console.
> And maybe add a first processed timestamp as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-578) JMX Instrumentation -
PerformanceCounter - last processed timestamp
Posted by "William Tam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
William Tam updated CAMEL-578:
------------------------------
Attachment: millisec_patch.txt
new patch that uses System.currentTimeMillis() to get time and fixes the incorrect unit of usec.
> JMX Instrumentation - PerformanceCounter - last processed timestamp
> -------------------------------------------------------------------
>
> Key: CAMEL-578
> URL: https://issues.apache.org/activemq/browse/CAMEL-578
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 1.4.0
>
> Attachments: jconsole.PNG, jconsole_nanosecond.PNG, millisec_patch.txt, nanosecnd-patch.txt, patch.txt, undo_nano_patch.txt
>
>
> Add a timestamp for the last completed exchange on the Camel JMX PerfformanceCounter.
> Its very nice to be able to see this information in the JMX console.
> And maybe add a first processed timestamp as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-578) JMX Instrumentation -
PerformanceCounter - last processed timestamp
Posted by "William Tam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43271#action_43271 ]
William Tam commented on CAMEL-578:
-----------------------------------
No idea why it displays usec other than making it look faster. :-)
> JMX Instrumentation - PerformanceCounter - last processed timestamp
> -------------------------------------------------------------------
>
> Key: CAMEL-578
> URL: https://issues.apache.org/activemq/browse/CAMEL-578
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Claus Ibsen
> Priority: Minor
> Fix For: 1.4.0
>
> Attachments: jconsole.PNG, patch.txt
>
>
> Add a timestamp for the last completed exchange on the Camel JMX PerfformanceCounter.
> Its very nice to be able to see this information in the JMX console.
> And maybe add a first processed timestamp as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-578) JMX Instrumentation -
PerformanceCounter - last processed timestamp
Posted by "William Tam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
William Tam updated CAMEL-578:
------------------------------
Attachment: jconsole_nanosecond.PNG
jconsole screenshot that shows perf counters in nanoseconds.
> JMX Instrumentation - PerformanceCounter - last processed timestamp
> -------------------------------------------------------------------
>
> Key: CAMEL-578
> URL: https://issues.apache.org/activemq/browse/CAMEL-578
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Claus Ibsen
> Priority: Minor
> Fix For: 1.4.0
>
> Attachments: jconsole.PNG, jconsole_nanosecond.PNG, nanosecnd-patch.txt, patch.txt
>
>
> Add a timestamp for the last completed exchange on the Camel JMX PerfformanceCounter.
> Its very nice to be able to see this information in the JMX console.
> And maybe add a first processed timestamp as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-578) JMX Instrumentation -
PerformanceCounter - last processed timestamp
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43276#action_43276 ]
Claus Ibsen commented on CAMEL-578:
-----------------------------------
William.
At first glance the nano second timing value doesn't give me good indication if the elapsed time is fast or not - we are so used to milli seconds.
Can you create a patch that uses millis instead?
And I do think the text in the jconsole should display the unit of the timing
MinProcessingTime [millis]
MeanProcessingTime [millis]
MaxProcessingTime [millis]
> JMX Instrumentation - PerformanceCounter - last processed timestamp
> -------------------------------------------------------------------
>
> Key: CAMEL-578
> URL: https://issues.apache.org/activemq/browse/CAMEL-578
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Claus Ibsen
> Priority: Minor
> Fix For: 1.4.0
>
> Attachments: jconsole.PNG, jconsole_nanosecond.PNG, nanosecnd-patch.txt, patch.txt
>
>
> Add a timestamp for the last completed exchange on the Camel JMX PerfformanceCounter.
> Its very nice to be able to see this information in the JMX console.
> And maybe add a first processed timestamp as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-578) JMX Instrumentation -
PerformanceCounter - last processed timestamp
Posted by "William Tam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
William Tam updated CAMEL-578:
------------------------------
Attachment: millisec_patch.txt
i think i attached a wrong file. here it is again.
> JMX Instrumentation - PerformanceCounter - last processed timestamp
> -------------------------------------------------------------------
>
> Key: CAMEL-578
> URL: https://issues.apache.org/activemq/browse/CAMEL-578
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 1.4.0
>
> Attachments: jconsole.PNG, jconsole_nanosecond.PNG, millisec_patch.txt, millisec_patch.txt, nanosecnd-patch.txt, patch.txt, undo_nano_patch.txt
>
>
> Add a timestamp for the last completed exchange on the Camel JMX PerfformanceCounter.
> Its very nice to be able to see this information in the JMX console.
> And maybe add a first processed timestamp as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CAMEL-578) JMX Instrumentation -
PerformanceCounter - last processed timestamp
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen reassigned CAMEL-578:
---------------------------------
Assignee: Claus Ibsen
> JMX Instrumentation - PerformanceCounter - last processed timestamp
> -------------------------------------------------------------------
>
> Key: CAMEL-578
> URL: https://issues.apache.org/activemq/browse/CAMEL-578
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 1.4.0
>
> Attachments: jconsole.PNG, jconsole_nanosecond.PNG, nanosecnd-patch.txt, patch.txt
>
>
> Add a timestamp for the last completed exchange on the Camel JMX PerfformanceCounter.
> Its very nice to be able to see this information in the JMX console.
> And maybe add a first processed timestamp as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-578) JMX Instrumentation -
PerformanceCounter - last processed timestamp
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43269#action_43269 ]
Claus Ibsen commented on CAMEL-578:
-----------------------------------
William good work.
I was wondering if you could take a look at the timing. It uses nano seconds but I am wondering why we divide the delta with 1000 when its passed to the performance counter.
counter.completedExchange((System.nanoTime() - startTime) / 1000);
And could the mbeans description be changed from usec to nano sec, as not everyone knows what a usec is.
And should we change to use the more common millis instead?
> JMX Instrumentation - PerformanceCounter - last processed timestamp
> -------------------------------------------------------------------
>
> Key: CAMEL-578
> URL: https://issues.apache.org/activemq/browse/CAMEL-578
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Claus Ibsen
> Priority: Minor
> Fix For: 1.4.0
>
> Attachments: jconsole.PNG, patch.txt
>
>
> Add a timestamp for the last completed exchange on the Camel JMX PerfformanceCounter.
> Its very nice to be able to see this information in the JMX console.
> And maybe add a first processed timestamp as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-578) JMX Instrumentation -
PerformanceCounter - last processed timestamp
Posted by "William Tam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
William Tam updated CAMEL-578:
------------------------------
Attachment: undo_nano_patch.txt
Here is a patch to change back to usec precision.
> JMX Instrumentation - PerformanceCounter - last processed timestamp
> -------------------------------------------------------------------
>
> Key: CAMEL-578
> URL: https://issues.apache.org/activemq/browse/CAMEL-578
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 1.4.0
>
> Attachments: jconsole.PNG, jconsole_nanosecond.PNG, nanosecnd-patch.txt, patch.txt, undo_nano_patch.txt
>
>
> Add a timestamp for the last completed exchange on the Camel JMX PerfformanceCounter.
> Its very nice to be able to see this information in the JMX console.
> And maybe add a first processed timestamp as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-578) JMX Instrumentation -
PerformanceCounter - last processed timestamp
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43281#action_43281 ]
Claus Ibsen commented on CAMEL-578:
-----------------------------------
William. I would have used System.currentTimeMillis instead. Isn't this better?
And I would write millis instead of usec as millis is the term used in Camel and most places.
> JMX Instrumentation - PerformanceCounter - last processed timestamp
> -------------------------------------------------------------------
>
> Key: CAMEL-578
> URL: https://issues.apache.org/activemq/browse/CAMEL-578
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 1.4.0
>
> Attachments: jconsole.PNG, jconsole_nanosecond.PNG, nanosecnd-patch.txt, patch.txt, undo_nano_patch.txt
>
>
> Add a timestamp for the last completed exchange on the Camel JMX PerfformanceCounter.
> Its very nice to be able to see this information in the JMX console.
> And maybe add a first processed timestamp as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-578) JMX Instrumentation -
PerformanceCounter - last processed timestamp
Posted by "William Tam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
William Tam updated CAMEL-578:
------------------------------
Attachment: patch.txt
Please review the attached patch.
> JMX Instrumentation - PerformanceCounter - last processed timestamp
> -------------------------------------------------------------------
>
> Key: CAMEL-578
> URL: https://issues.apache.org/activemq/browse/CAMEL-578
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Claus Ibsen
> Priority: Minor
> Attachments: jconsole.PNG, patch.txt
>
>
> Add a timestamp for the last completed exchange on the Camel JMX PerfformanceCounter.
> Its very nice to be able to see this information in the JMX console.
> And maybe add a first processed timestamp as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-578) JMX Instrumentation -
PerformanceCounter - last processed timestamp
Posted by "William Tam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
William Tam updated CAMEL-578:
------------------------------
Attachment: jconsole.PNG
Here is how it will look like.
> JMX Instrumentation - PerformanceCounter - last processed timestamp
> -------------------------------------------------------------------
>
> Key: CAMEL-578
> URL: https://issues.apache.org/activemq/browse/CAMEL-578
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Claus Ibsen
> Priority: Minor
> Attachments: jconsole.PNG, patch.txt
>
>
> Add a timestamp for the last completed exchange on the Camel JMX PerfformanceCounter.
> Its very nice to be able to see this information in the JMX console.
> And maybe add a first processed timestamp as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (CAMEL-578) JMX Instrumentation - PerformanceCounter
- last processed timestamp
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen closed CAMEL-578.
-----------------------------
Resolution: Fixed
William. Thanks for taking this up and providing patches and screenshots. Feel free to continue your contributions.
> JMX Instrumentation - PerformanceCounter - last processed timestamp
> -------------------------------------------------------------------
>
> Key: CAMEL-578
> URL: https://issues.apache.org/activemq/browse/CAMEL-578
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 1.4.0
>
> Attachments: jconsole.PNG, jconsole_nanosecond.PNG, millisec_patch.txt, millisec_patch.txt, nanosecnd-patch.txt, patch.txt, undo_nano_patch.txt
>
>
> Add a timestamp for the last completed exchange on the Camel JMX PerfformanceCounter.
> Its very nice to be able to see this information in the JMX console.
> And maybe add a first processed timestamp as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (CAMEL-578) JMX Instrumentation -
PerformanceCounter - last processed timestamp
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen reopened CAMEL-578:
-------------------------------
> JMX Instrumentation - PerformanceCounter - last processed timestamp
> -------------------------------------------------------------------
>
> Key: CAMEL-578
> URL: https://issues.apache.org/activemq/browse/CAMEL-578
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 1.3.0
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 1.4.0
>
> Attachments: jconsole.PNG, jconsole_nanosecond.PNG, nanosecnd-patch.txt, patch.txt, undo_nano_patch.txt
>
>
> Add a timestamp for the last completed exchange on the Camel JMX PerfformanceCounter.
> Its very nice to be able to see this information in the JMX console.
> And maybe add a first processed timestamp as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.