[GitHub] zachgk commented on a change in pull request #13330: [MXNET-1222] Scala Inference "Pandora Box"

[GitBox <gi...@apache.org>]

zachgk commented on a change in pull request #13330: [MXNET-1222] Scala Inference "Pandora Box"
URL: https://github.com/apache/incubator-mxnet/pull/13330#discussion_r235123676
 
 

 ##########
 File path: scala-package/infer/src/main/scala/org/apache/mxnet/infer/Predictor.scala
 ##########
 @@ -76,6 +78,21 @@ class Predictor(modelPathPrefix: String,
 
   private val logger = LoggerFactory.getLogger(classOf[Predictor])
 
+  /*
+    By setting -Dmxnet.disableShapeCheck=true would disable the data Shape
+    Check of the predictor. Some model may allow different lens of the data
+    such as Seq2Seq, however there maybe risk of crashes if the lens beyond
+    the acceptable range of the model
+   */
+  private val traceProperty = "mxnet.disableShapeCheck"
+  lazy val shapeCheckDisabld = {
 
 Review comment:
   shapeCheckDisabld -> shapeCheckDisabled

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services