You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Oleg Kalnichevski (JIRA)" <ji...@apache.org> on 2012/07/26 11:38:34 UTC
[jira] [Resolved] (HTTPCORE-302) setEntity should consume the old
entity first
[ https://issues.apache.org/jira/browse/HTTPCORE-302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Oleg Kalnichevski resolved HTTPCORE-302.
----------------------------------------
Resolution: Fixed
Fix Version/s: (was: 4.3)
4.3-alpha1
Patch checked in. I changed javadocs for HttpResponse#setEntity slightly. Please review.
Oleg
> setEntity should consume the old entity first
> ---------------------------------------------
>
> Key: HTTPCORE-302
> URL: https://issues.apache.org/jira/browse/HTTPCORE-302
> Project: HttpComponents HttpCore
> Issue Type: Improvement
> Components: HttpCore
> Affects Versions: 4.2.1
> Reporter: William R. Speirs
> Fix For: 4.3-alpha1
>
> Attachments: HTTPCORE-302.diff
>
>
> The setEntity() method of HttpResponse makes it very easy to leak connections if used without consuming the old entity first. I'm proposing the following enhancements:
> 1) add a Javadoc note to the setEntity() method of HttpResponse that says something like: "Implementations might not consume an existing entity. Callers should consume any existing entity before calling this method."
> 2) either add a consumeAndSetEntity() method to BasicHttpResponse which consumes an existing entity before setting the reference, OR change the implementation of setEntity() to consume any existing entity first. (My vote is for the later, although it will change existing behavior, it shouldn't negatively impact any callers.)
> The reason for this improvement request is simply that I've been burned a few times by calling setEntity() without first consuming the existing entity, and I think we could make this more user friendly. I'm happy to submit a patch once we decide what should be done with #2.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org