You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/09/28 08:11:33 UTC
[GitHub] [flink] zhuzhurk commented on a change in pull request #13473: [FLINK-19264][runtime] Add JobID to ExecutionAttemptID
zhuzhurk commented on a change in pull request #13473:
URL: https://github.com/apache/flink/pull/13473#discussion_r495757745
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionAttemptID.java
##########
@@ -33,31 +36,46 @@
private static final long serialVersionUID = -1169683445778281344L;
+ private final JobID jobId;
private final ExecutionVertexID executionVertexId;
private final int attemptNumber;
/**
* Get a random execution attempt id.
*/
public ExecutionAttemptID() {
- this(new ExecutionVertexID(new JobVertexID(), 0), 0);
+ this(new JobID(), new ExecutionVertexID(new JobVertexID(), 0), 0);
}
- public ExecutionAttemptID(ExecutionVertexID executionVertexId, int attemptNumber) {
+ public ExecutionAttemptID(JobID jobId, ExecutionVertexID executionVertexId, int attemptNumber) {
Preconditions.checkState(attemptNumber >= 0);
+ this.jobId = jobId;
Review comment:
need to check not null
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org