You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by mxm <gi...@git.apache.org> on 2016/09/19 16:53:45 UTC

[GitHub] flink pull request #2514: [FLINK-4555] add test case to test Yarn cluster sh...

GitHub user mxm opened a pull request:

    https://github.com/apache/flink/pull/2514

    [FLINK-4555] add test case to test Yarn cluster shutdown

    In the first commit, it ensures that the cluster shutdown is working as expected.
    
    In a second commit, it gives the ResourceManager more time to unregister the application. This is not important as Yarn also monitors processes but should ensure that everything shuts down cleanly.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mxm/flink FLINK-4555

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2514.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2514
    
----
commit 9f22fe8c5967e4ac77feed0f83e36f5daa7ba74c
Author: Maximilian Michels <mx...@apache.org>
Date:   2016-09-19T16:45:05Z

    [FLINK-4555] add test case to test Yarn cluster shutdown

commit 7989dfa73f23fdb262b5d6f466c05579132d9d27
Author: Maximilian Michels <mx...@apache.org>
Date:   2016-09-19T16:45:37Z

    wait for ResourceManager to cleanly unregister application
    
    This ensures that the ResourceManager has enough time to unregister the
    application for shutting down.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #2514: [FLINK-4555] add test case to test Yarn cluster sh...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/2514


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #2514: [FLINK-4555] add test case to test Yarn cluster shutdown

Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the issue:

    https://github.com/apache/flink/pull/2514
  
    Actually, I have written a much better test case for this some time ago, see https://github.com/apache/flink/blob/142912b031df42d2abe43b41e98be5596cb3a7f9/flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/ClusterShutdownITCase.java
    
    So I would only merge the addition to the ResourceManager shutdown.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---