You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by Igor Galić <i....@brainsware.org> on 2013/11/14 11:42:39 UTC

Re: git commit: reliably recreate the same tar-ball from the same content

Fellow Traffic Server Developers,

I would like to draw your attention to this commit of mine.

Following a discussion on IRC yesterday, I spent this morning
writing m4 and testing the results.

This second throw gives us a convenience wrapper for release
managers to create tar-balls and git tags that will reliably
look the exact same.

   RFC.

-- i


----- Original Message -----
> Updated Branches:
>   refs/heads/master b21deabaf -> cdfe125a1
> 
> 
> reliably recreate the same tar-ball from the same content
> 
> if the content of the tree is the same, we now create the same
> tarballs with the same and sha1sums. We do this, by fixing the mtime of
> all objects in the tarball to that of our ./configure.ac
> 
> In order for the content to be the same, we no longer rely on simply
> calling $(MAKE) asf-dist-sign with a different version, but rather have
> special targets, which simply inject the $(RC) variable.
> 
> These targets are entirely convinience wrappers for Release managers.
> 
> NOTE the GPG signature will always different, because it's a cryptographic
> signature. In order to release 4.2.16-rc7 as 4.2.16, we can either call
> 
>     make release
> 
> or, simply rename the tar-ball. The content of the tar-ball will be the
> same, regardless.
> 
> 
> Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
> Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/cdfe125a
> Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/cdfe125a
> Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/cdfe125a
> 
> Branch: refs/heads/master
> Commit: cdfe125a12129d39969a4f2a585351392b181ea3
> Parents: b21deab
> Author: Igor Gali�� <i....@brainsware.org>
> Authored: Thu Nov 14 10:38:05 2013 +0100
> Committer: Igor Gali�� <i....@brainsware.org>
> Committed: Thu Nov 14 11:32:34 2013 +0100
> 
> ----------------------------------------------------------------------
>  Makefile.am | 14 +++++++++++---
>  1 file changed, 11 insertions(+), 3 deletions(-)
> ----------------------------------------------------------------------
> 
> 
> http://git-wip-us.apache.org/repos/asf/trafficserver/blob/cdfe125a/Makefile.am
> ----------------------------------------------------------------------
> diff --git a/Makefile.am b/Makefile.am
> index c92cdf7..2534837 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -62,7 +62,11 @@ asf-distdir:
>  	rm -rf -- $(distdir)/autom4te.cache $(distdir)/.git $(distdir)/.gitignore
>  	$(distdir)/ci
>  
>  asf-dist: asf-distdir
> -	tardir=$(distdir) && $(am__tar) | bzip2 -9 -c >$(distdir).tar.bz2
> +	tardir=$(distdir) && $(am__tar) --mtime=./configure.ac | bzip2 -9 -c
> >$(distdir).tar.bz2
> +	@$(am__remove_distdir)
> +
> +asf-dist-rc: asf-distdir
> +	tardir=$(distdir) && $(am__tar) --mtime=./configure.ac | bzip2 -9 -c
> >$(distdir)-rc$(RC).tar.bz2
>  	@$(am__remove_distdir)
>  
>  asf-dist-sign: asf-dist
> @@ -70,11 +74,15 @@ asf-dist-sign: asf-dist
>  	sha1sum -b $(distdir).tar.bz2 >$(distdir).tar.bz2.sha1
>  	gpg --armor --output $(distdir).tar.bz2.asc  --detach-sig
>  	$(distdir).tar.bz2
>  
> +asf-dist-sign-rc: asf-dist-rc
> +	md5sum -b $(distdir)-rc$(RC).tar.bz2 >$(distdir)-rc$(RC).tar.bz2.md5
> +	sha1sum -b $(distdir)-rc$(RC).tar.bz2 >$(distdir)-rc$(RC).tar.bz2.sha1
> +	gpg --armor --output $(distdir)-rc$(RC).tar.bz2.asc  --detach-sig
> $(distdir)-rc$(RC).tar.bz2
> +
>  release: asf-dist-sign
>  	git tag -fs -m "Release $(VERSION)" $(VERSION)
>  
> -rel-candidate:
> -	$(MAKE) asf-dist-sign VERSION=$(VERSION)-rc$(RC)
> +rel-candidate: asf-dist-sign-rc
>  	git tag -fs -m "Release Candidate $(VERSION)-rc$(RC)" $(VERSION)-rc$(RC)
>  
>  examples: all
> 
> 

-- 
Igor Galić

Tel: +43 (0) 664 886 22 883
Mail: i.galic@brainsware.org
URL: http://brainsware.org/
GPG: 8716 7A9F 989B ABD5 100F  4008 F266 55D6 2998 1641