[GitHub] [hive] aasha commented on a change in pull request #1223: HIVE-23813 : Fix flaky tests due to JDO Exception

[GitBox <gi...@apache.org>]

aasha commented on a change in pull request #1223:
URL: https://github.com/apache/hive/pull/1223#discussion_r451545094



##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ReplicationMetricsMaintTask.java
##########
@@ -63,13 +63,12 @@ public void run() {
       if (!MetastoreConf.getBoolVar(conf, ConfVars.SCHEDULED_QUERIES_ENABLED)) {

Review comment:
       Metrics are always enabled by default. So didn't want to introduce a new config.
   The metric collection depends if the scheduled queries are enabled. If not, there is no metric collection for replication as the primary key for the table is schedule id.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org