You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@linkis.apache.org by GitBox <gi...@apache.org> on 2022/08/31 10:09:39 UTC
[GitHub] [incubator-linkis] binbinCheng opened a new pull request, #3166: [linkis-orchestrator-ecm-plugin] Modification of scala file floating red
binbinCheng opened a new pull request, #3166:
URL: https://github.com/apache/incubator-linkis/pull/3166
[linkis-orchestrator-ecm-plugin] Modification of scala file floating red
Related issues: https://github.com/apache/incubator-linkis/issues/2857
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] casionone commented on a diff in pull request #3166: [linkis-orchestrator-ecm-plugin] Modification of scala file floating red
Posted by GitBox <gi...@apache.org>.
casionone commented on code in PR #3166:
URL: https://github.com/apache/incubator-linkis/pull/3166#discussion_r962112787
##########
linkis-orchestrator/plugin/linkis-orchestrator-ecm-plugin/src/main/scala/org/apache/linkis/orchestrator/ecm/LoadBalanceLabelEngineConnManager.scala:
##########
@@ -64,32 +64,17 @@ class LoadBalanceLabelEngineConnManager extends ComputationEngineConnManager wit
}
}
- /**
- * 申请获取一个Mark
- * 1. 如果没有对应的Mark就生成新的 2. 一个MarkRequest对应多个Mark，一个Mark对应一个Engine 3.
- * 如果存在bindEngineLabel则需要在jobStart的时候随机选择一个，并缓存给后续jobGroup使用，在jobEnd的时候删除缓存 4. 将Mark进行返回
- *
- * @param markReq
- * @return
- */
Review Comment:
If the Chinese annotation is deleted, please add the corresponding English
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] casionone merged pull request #3166: [linkis-orchestrator-ecm-plugin] Modification of scala file floating red
Posted by GitBox <gi...@apache.org>.
casionone merged PR #3166:
URL: https://github.com/apache/incubator-linkis/pull/3166
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] codecov[bot] commented on pull request #3166: [linkis-orchestrator-ecm-plugin] Modification of scala file floating red
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #3166:
URL: https://github.com/apache/incubator-linkis/pull/3166#issuecomment-1232771484
# [Codecov](https://codecov.io/gh/apache/incubator-linkis/pull/3166?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3166](https://codecov.io/gh/apache/incubator-linkis/pull/3166?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4c21577) into [dev-1.3.1](https://codecov.io/gh/apache/incubator-linkis/commit/3c452c3cf2c8338be5e5595a64061db10189b445?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3c452c3) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## dev-1.3.1 #3166 +/- ##
===============================================
+ Coverage 16.37% 16.40% +0.02%
- Complexity 1382 1384 +2
===============================================
Files 779 779
Lines 25331 25331
Branches 3584 3584
===============================================
+ Hits 4149 4156 +7
+ Misses 20639 20634 -5
+ Partials 543 541 -2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-linkis/pull/3166?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...s/scheduler/queue/fifoqueue/FIFOUserConsumer.scala](https://codecov.io/gh/apache/incubator-linkis/pull/3166/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLXNjaGVkdWxlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9zY2hlZHVsZXIvcXVldWUvZmlmb3F1ZXVlL0ZJRk9Vc2VyQ29uc3VtZXIuc2NhbGE=) | `37.61% <0.00%> (+1.83%)` | :arrow_up: |
| [...linkis/jobhistory/restful/api/QueryRestfulApi.java](https://codecov.io/gh/apache/incubator-linkis/pull/3166/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLXB1YmxpYy1lbmhhbmNlbWVudHMvbGlua2lzLWpvYmhpc3Rvcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2xpbmtpcy9qb2JoaXN0b3J5L3Jlc3RmdWwvYXBpL1F1ZXJ5UmVzdGZ1bEFwaS5qYXZh) | `35.11% <0.00%> (+3.81%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org