You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/02/16 13:13:07 UTC
[GitHub] [shardingsphere] sandynz opened a new pull request #15452: Update MySQL checksum SQL for scaling
sandynz opened a new pull request #15452:
URL: https://github.com/apache/shardingsphere/pull/15452
Changes proposed in this pull request:
- Update MySQL checksum SQL. `SUM` function might cause integer overflow, and `BIT_XOR` is better hash function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #15452: Update MySQL checksum SQL for scaling
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #15452:
URL: https://github.com/apache/shardingsphere/pull/15452
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sandynz commented on a change in pull request #15452: Update MySQL checksum SQL for scaling
Posted by GitBox <gi...@apache.org>.
sandynz commented on a change in pull request #15452:
URL: https://github.com/apache/shardingsphere/pull/15452#discussion_r809658942
##########
File path: shardingsphere-kernel/shardingsphere-data-pipeline/shardingsphere-data-pipeline-dialect/shardingsphere-data-pipeline-mysql/src/main/java/org/apache/shardingsphere/data/pipeline/mysql/check/consistency/CRC32MatchMySQLSingleTableDataCalculator.java
##########
@@ -58,17 +58,17 @@ public String getAlgorithmType() {
public Iterable<Object> calculate(final DataCalculateParameter dataCalculateParameter) {
String logicTableName = dataCalculateParameter.getLogicTableName();
List<Long> result = dataCalculateParameter.getColumnNames().stream().map(each -> {
- String sql = SQL_BUILDER.buildSumCrc32SQL(logicTableName, each);
+ String sql = SQL_BUILDER.buildChecksumSQL(logicTableName, each);
Review comment:
Recovered to `buildCrc32SQL`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on a change in pull request #15452: Update MySQL checksum SQL for scaling
Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #15452:
URL: https://github.com/apache/shardingsphere/pull/15452#discussion_r809652894
##########
File path: shardingsphere-kernel/shardingsphere-data-pipeline/shardingsphere-data-pipeline-dialect/shardingsphere-data-pipeline-mysql/src/main/java/org/apache/shardingsphere/data/pipeline/mysql/check/consistency/CRC32MatchMySQLSingleTableDataCalculator.java
##########
@@ -58,17 +58,17 @@ public String getAlgorithmType() {
public Iterable<Object> calculate(final DataCalculateParameter dataCalculateParameter) {
String logicTableName = dataCalculateParameter.getLogicTableName();
List<Long> result = dataCalculateParameter.getColumnNames().stream().map(each -> {
- String sql = SQL_BUILDER.buildSumCrc32SQL(logicTableName, each);
+ String sql = SQL_BUILDER.buildChecksumSQL(logicTableName, each);
Review comment:
Why change method name to `check sum`, but class name still `CRC32`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org