[jira] [Commented] (YARN-1297) FairScheduler: Move some logs to debug and check if debug logging is enabled

["Hudson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15257971#comment-15257971 ] 

Hudson commented on YARN-1297:
------------------------------

FAILURE: Integrated in Hadoop-trunk-Commit #9669 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/9669/])
YARN-1297. FairScheduler: Move some logs to debug and check if debug (kasha: rev 4b1dcbbe0c1d0036f65283be4b25d9b2211abed3)
* hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSAppAttempt.java
* hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerNode.java
* hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FairScheduler.java
* hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmcontainer/RMContainerImpl.java


> FairScheduler: Move some logs to debug and check if debug logging is enabled
> ----------------------------------------------------------------------------
>
>                 Key: YARN-1297
>                 URL: https://issues.apache.org/jira/browse/YARN-1297
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: fairscheduler
>            Reporter: Sandy Ryza
>            Assignee: Yufei Gu
>         Attachments: YARN-1297-1.patch, YARN-1297-2.patch, YARN-1297.005.patch, YARN-1297.006.patch, YARN-1297.3.patch, YARN-1297.4.patch, YARN-1297.4.patch, YARN-1297.patch, YARN-1297.patch
>
>
> I ran the Fair Scheduler's core scheduling loop through a profiler tool and identified a bunch of minimally invasive changes that can shave off a few milliseconds.
> The main one is demoting a couple INFO log messages to DEBUG, which brought my benchmark down from 16000 ms to 6000.
> A few others (which had way less of an impact) were
> * Most of the time in comparisons was being spent in Math.signum.  I switched this to direct ifs and elses and it halved the percent of time spent in comparisons.
> * I removed some unnecessary instantiations of Resource objects
> * I made it so that queues' usage wasn't calculated from the applications up each time getResourceUsage was called.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)