You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "gnodet (via GitHub)" <gi...@apache.org> on 2026/09/10 16:01:35 UTC
[PR] CAMEL-23677: Fix SjmsConnectionRecoveryTest to run on s390x [camel]
gnodet opened a new pull request, #26275:
URL: https://github.com/apache/camel/pull/26275
## Summary
Fix `SjmsConnectionRecoveryTest` so it runs on **all architectures including s390x**, by replacing the Testcontainers-based `ArtemisContainer` with an embedded Artemis broker that opens a real TCP acceptor.
## Root Cause
The test was previously annotated with `@DisabledOnOs(architectures = {"s390x"})` because `ArtemisContainer` pulls the Docker image `icr.io/s390x-oss/activemq-artemis-broker-s390x:2.0.2`, which cannot be fetched in CI on s390x (container registry access issue). An earlier fix attempt (PR #25266 / commit `670620c04a0d`) was reverted (commit `4b99a3660d50`) for this reason.
## Fix
Replace `ArtemisContainer` (Testcontainers) with `ArtemisServiceFactory.createTCPAllProtocolsService()`, which starts an **embedded** Artemis broker that listens on a real TCP port — no Docker image needed, no registry access required.
Key changes:
- Drop `@DisabledOnOs(architectures = {"s390x"})`
- Replace `private static ArtemisContainer broker` + `@BeforeAll`/`@AfterAll` lifecycle with `@RegisterExtension static ArtemisService service`
- Derive connection URL from `service.serviceAddress()` instead of the container's host/port
The test semantics are preserved: a real TCP connection is used, so `connection.close()` genuinely kills sessions and consumer subscriptions, exercising the recovery path under test — matching the Oracle AQ customer scenario.
## Test
```
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.694 s
```
Run locally with: `mvn test -Dtest=SjmsConnectionRecoveryTest -pl components/camel-sjms -Dlicense.skip`
---
_Hermes Agent (Claude Sonnet 4.6) on behalf of Guillaume Nodet_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-23677: Fix SjmsConnectionRecoveryTest to run on s390x [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #26275:
URL: https://github.com/apache/camel/pull/26275
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-23677: Fix SjmsConnectionRecoveryTest to run on s390x [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26275:
URL: https://github.com/apache/camel/pull/26275#issuecomment-5621668405
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot although they are normally detected and executed by CI.
* You can label PRs using `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
:warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-23677: Fix SjmsConnectionRecoveryTest to run on s390x [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26275:
URL: https://github.com/apache/camel/pull/26275#issuecomment-5622047305
<!-- ci-tested-modules -->
:test_tube: **CI tested the following changed modules:**
- `components/camel-sjms`
---
<details><summary>:microscope: Scalpel shadow comparison — Scalpel: 1 tested, 0 compile-only — current: 11 all tested</summary>
[Maveniverse Scalpel](https://github.com/maveniverse/scalpel) detected **1 affected modules** (current approach: 11).
<details><summary>Modules only in current approach (10)</summary>
- `camel-jbang-mcp`
- `camel-jbang-plugin-mcp`
- `camel-jbang-plugin-route-parser`
- `camel-jbang-plugin-tui`
- `camel-jbang-plugin-validate`
- `camel-launcher-container`
- `camel-mllp`
- `camel-sjms2`
- `camel-yaml-dsl-validator`
- `camel-yaml-dsl-validator-maven-plugin`
</details>
**Skip-tests mode would test 1 modules** (1 direct + 0 downstream), **skip tests for 0** (generated code, meta-modules)
<details><summary>Modules Scalpel would test (1)</summary>
- `camel-sjms`
</details>
> :information_source: Shadow mode — Scalpel observes but does not affect test execution. [Learn more](https://github.com/maveniverse/scalpel)
</details>
<details><summary>All tested modules (11 modules, 2m 41s total)</summary>
**Total reactor time:** 2m 41s
| Module | Duration | Status |
| --- | --- | --- |
| Camel :: Simple JMS | 50.9s | SUCCESS |
| Camel :: JBang :: Plugin :: TUI | 45.2s | SUCCESS |
| Camel :: JBang :: MCP | 38.1s | SUCCESS |
| Camel :: Simple JMS2 | 9.1s | SUCCESS |
| Camel :: YAML DSL :: Validator | 5.8s | SUCCESS |
| Camel :: YAML DSL :: Validator Maven Plugin | 4.2s | SUCCESS |
| Camel :: JBang :: Plugin :: MCP | 2.7s | SUCCESS |
| Camel :: JBang :: Plugin :: Route Parser | 2.2s | SUCCESS |
| Camel :: Launcher :: Container | 1.6s | SUCCESS |
| Camel :: JBang :: Plugin :: Validate | 1.0s | SUCCESS |
| Camel :: MLLP | n/a | |
**Top 20 slowest modules:**
- `Camel :: Simple JMS` (50.9s)
- `Camel :: JBang :: Plugin :: TUI` (45.2s)
- `Camel :: JBang :: MCP` (38.1s)
- `Camel :: Simple JMS2` (9.1s)
- `Camel :: YAML DSL :: Validator` (5.8s)
- `Camel :: YAML DSL :: Validator Maven Plugin` (4.2s)
- `Camel :: JBang :: Plugin :: MCP` (2.7s)
- `Camel :: JBang :: Plugin :: Route Parser` (2.2s)
- `Camel :: Launcher :: Container` (1.6s)
- `Camel :: JBang :: Plugin :: Validate` (1.0s)
</details>
---
:gear: [View full build and test results](https://github.com/apache/camel/actions/runs/34499455838)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org