[DISCUSS] Patches, pull requests or both?

[Julian Hyde <jh...@apache.org>]

Some projects (e.g. Hive) only accept patches, and some (e.g. Spark)
only accept github pull requests.

Should we accept patches? I prefer pull requests. I am torn whether to
accept patches. On one hand, we make it easier for contributors. On
the other hand, we can provide a better process (e.g. automatic builds
& tests of all proposed contributions) if we keep the process as
simple as possible.

The Spark project have shown that following the github model is very
efficient and does not deter contributors.

Should each Jira case have a “Submit patch” button?

Julian

Re: [DISCUSS] Patches, pull requests or both?

[Vladimir Sitnikov <si...@gmail.com>]

+1 for pull requests.

I find pull requests easier to produce/review

Vladimir

Re: [DISCUSS] Patches, pull requests or both?

[Yash Sharma <ya...@gmail.com>]

My few paisa(cents) being newbie on both Drill and Calcite,
Drill uses patch + review board which provides a really easy entry for new
users and a matured reviewing capabilities, and
Calcite which uses pull requests which i was not so comfortable when i
started but find useful now.

I would currently recommend pull requests as its a very neat way to go
ahead but i would also request volunteering for assisting newbies who might
not be in n a comfortable state yet.
On 21/11/2014 12:53 am, "Julian Hyde" <jh...@apache.org> wrote:

> Some projects (e.g. Hive) only accept patches, and some (e.g. Spark)
> only accept github pull requests.
>
> Should we accept patches? I prefer pull requests. I am torn whether to
> accept patches. On one hand, we make it easier for contributors. On
> the other hand, we can provide a better process (e.g. automatic builds
> & tests of all proposed contributions) if we keep the process as
> simple as possible.
>
> The Spark project have shown that following the github model is very
> efficient and does not deter contributors.
>
> Should each Jira case have a “Submit patch” button?
>
> Julian
>