You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "Ahmet Altay (JIRA)" <ji...@apache.org> on 2017/01/27 22:41:24 UTC

[jira] [Closed] (BEAM-1100) Consider removing pylint from mvn verify

     [ https://issues.apache.org/jira/browse/BEAM-1100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ahmet Altay closed BEAM-1100.
-----------------------------
       Resolution: Fixed
    Fix Version/s: Not applicable

> Consider removing pylint from mvn verify
> ----------------------------------------
>
>                 Key: BEAM-1100
>                 URL: https://issues.apache.org/jira/browse/BEAM-1100
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-py
>            Reporter: Ahmet Altay
>            Assignee: Ahmet Altay
>            Priority: Critical
>             Fix For: Not applicable
>
>
> pylint depends on git commands for getting a list of changed files to run the linter on. This does not make sense in some cases (for example when in the case code was copied/packaged out of git structure). A few possible remedies could be considered:
> - Remove pylint step from mvn verify
> - Add an option to pylint run on whole code base and use this in mvn verify
> - Change pylint to run on the whole code base (instead of just changed files)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)