You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2017/10/27 10:29:19 UTC
Review Request 63358: Added the stub for OfferOperationStatusUpdate
handler in the master.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63358/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, Gaston Kleiman, Greg Mann, and Jan Schlicht.
Repository: mesos
Description
-------
Added the stub for OfferOperationStatusUpdate handler in the master.
Diffs
-----
src/master/master.hpp a3c9530e340b14b739da90851227f8eed254b4ac
src/master/master.cpp 4b76648b4887724e166ff95e002ee26c8bfef006
Diff: https://reviews.apache.org/r/63358/diff/1/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 63358: Added the stub for
OfferOperationStatusUpdate handler in the master.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63358/#review189438
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 62903.
Failed command: `python.exe .\support\apply-reviews.py -n -r 62903`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63358
Relevant logs:
- [apply-review-62903-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63358/logs/apply-review-62903-stdout.log):
```
error: patch failed: include/mesos/resource_provider/resource_provider.proto:70
error: include/mesos/resource_provider/resource_provider.proto: patch does not apply
error: patch failed: include/mesos/v1/resource_provider/resource_provider.proto:70
error: include/mesos/v1/resource_provider/resource_provider.proto: patch does not apply
error: patch failed: src/resource_provider/manager.cpp:155
error: src/resource_provider/manager.cpp: patch does not apply
```
- Mesos Reviewbot Windows
On Oct. 27, 2017, 10:29 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63358/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2017, 10:29 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Gaston Kleiman, Greg Mann, and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added the stub for OfferOperationStatusUpdate handler in the master.
>
>
> Diffs
> -----
>
> src/master/master.hpp a3c9530e340b14b739da90851227f8eed254b4ac
> src/master/master.cpp 4b76648b4887724e166ff95e002ee26c8bfef006
>
>
> Diff: https://reviews.apache.org/r/63358/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 63358: Added the stub for
OfferOperationStatusUpdate handler in the master.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63358/#review189426
-----------------------------------------------------------
Bad patch!
Reviews applied: [63358, 63356, 63312, 63105, 61946, 61810, 63104, 63094, 62903, 63001]
Failed command: python support/apply-reviews.py -n -r 62903
Error:
2017-10-27 13:10:31 URL:https://reviews.apache.org/r/62903/diff/raw/ [16204/16204] -> "62903.patch" [1]
error: patch failed: include/mesos/resource_provider/resource_provider.proto:70
error: include/mesos/resource_provider/resource_provider.proto: patch does not apply
error: patch failed: include/mesos/v1/resource_provider/resource_provider.proto:70
error: include/mesos/v1/resource_provider/resource_provider.proto: patch does not apply
error: patch failed: src/resource_provider/manager.cpp:155
error: src/resource_provider/manager.cpp: patch does not apply
Full log: https://builds.apache.org/job/Mesos-Reviewbot/19913/console
- Mesos Reviewbot
On Oct. 27, 2017, 10:29 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63358/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2017, 10:29 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Gaston Kleiman, Greg Mann, and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added the stub for OfferOperationStatusUpdate handler in the master.
>
>
> Diffs
> -----
>
> src/master/master.hpp a3c9530e340b14b739da90851227f8eed254b4ac
> src/master/master.cpp 4b76648b4887724e166ff95e002ee26c8bfef006
>
>
> Diff: https://reviews.apache.org/r/63358/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 63358: Added the stub for
OfferOperationStatusUpdate handler in the master.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63358/#review189524
-----------------------------------------------------------
Bad patch!
Reviews applied: [63358, 63398, 63397, 63396, 63356, 63399, 63312, 63105, 61946, 61810, 63104, 63094, 62903, 63001]
Failed command: python support/apply-reviews.py -n -r 63312
Error:
2017-10-29 18:40:37 URL:https://reviews.apache.org/r/63312/diff/raw/ [15399/15399] -> "63312.patch" [1]
error: patch failed: src/v1/resources.cpp:1814
error: src/v1/resources.cpp: patch does not apply
Full log: https://builds.apache.org/job/Mesos-Reviewbot/19931/console
- Mesos Reviewbot
On Oct. 29, 2017, 3:55 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63358/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2017, 3:55 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Gaston Kleiman, Greg Mann, and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added the stub for OfferOperationStatusUpdate handler in the master.
>
>
> Diffs
> -----
>
> src/master/master.hpp a3c9530e340b14b739da90851227f8eed254b4ac
> src/master/master.cpp 5b2c9a006d89265783d49409efd802c62be554f6
>
>
> Diff: https://reviews.apache.org/r/63358/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 63358: Added the stub for
OfferOperationStatusUpdate handler in the master.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63358/#review189538
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 63312.
Failed command: `python.exe .\support\apply-reviews.py -n -r 63312`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63358
Relevant logs:
- [apply-review-63312-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63358/logs/apply-review-63312-stdout.log):
```
error: patch failed: src/v1/resources.cpp:1814
error: src/v1/resources.cpp: patch does not apply
```
- Mesos Reviewbot Windows
On Oct. 29, 2017, 3:55 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63358/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2017, 3:55 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Gaston Kleiman, Greg Mann, and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added the stub for OfferOperationStatusUpdate handler in the master.
>
>
> Diffs
> -----
>
> src/master/master.hpp a3c9530e340b14b739da90851227f8eed254b4ac
> src/master/master.cpp 5b2c9a006d89265783d49409efd802c62be554f6
>
>
> Diff: https://reviews.apache.org/r/63358/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 63358: Added the stub for
OfferOperationStatusUpdate handler in the master.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63358/#review189562
-----------------------------------------------------------
Ship it!
src/master/master.hpp
Lines 477-479 (patched)
<https://reviews.apache.org/r/63358/#comment266689>
I am not sure what the ordering was here, but I trust your judgement.
- Benjamin Bannier
On Oct. 29, 2017, 4:55 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63358/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2017, 4:55 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Gaston Kleiman, Greg Mann, and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added the stub for OfferOperationStatusUpdate handler in the master.
>
>
> Diffs
> -----
>
> src/master/master.hpp a3c9530e340b14b739da90851227f8eed254b4ac
> src/master/master.cpp 5b2c9a006d89265783d49409efd802c62be554f6
>
>
> Diff: https://reviews.apache.org/r/63358/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 63358: Added the stub for
OfferOperationStatusUpdate handler in the master.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63358/
-----------------------------------------------------------
(Updated Oct. 29, 2017, 3:55 p.m.)
Review request for mesos, Benjamin Bannier, Gaston Kleiman, Greg Mann, and Jan Schlicht.
Changes
-------
REbased.
Repository: mesos
Description
-------
Added the stub for OfferOperationStatusUpdate handler in the master.
Diffs (updated)
-----
src/master/master.hpp a3c9530e340b14b739da90851227f8eed254b4ac
src/master/master.cpp 5b2c9a006d89265783d49409efd802c62be554f6
Diff: https://reviews.apache.org/r/63358/diff/2/
Changes: https://reviews.apache.org/r/63358/diff/1-2/
Testing
-------
make check
Thanks,
Jie Yu