You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by gaohoward <gi...@git.apache.org> on 2014/11/25 15:15:55 UTC
[GitHub] activemq-6 pull request: ACTIVEMQ6-42 Fix FORCED_DELIVERY_MESSAGE ...
GitHub user gaohoward opened a pull request:
https://github.com/apache/activemq-6/pull/24
ACTIVEMQ6-42 Fix FORCED_DELIVERY_MESSAGE dependent on hornetq naming
When dealing with receiveNoWait messages, a special message with
a property called _activemq.forced.delivery.seq is being sent.
This property used to be _hornetq.forced.delivery.seq. In order
to be compatible with 'old' hornetq clients, this fix does the
following:
1. Determine the client type of a client during protocol handshake
phase of a connection. New clients will connect with a 'ACTIVEMQ'
and old clients will do with either 'HORNETQ' or nothing.
2. The clien types are identified by a new enum type ClientType.
It has two values 'AMQ' (new clients) and 'HQ' (old ones).
3. When a forced delivery is being sent, put a proper property
to the special message based on the client type. If it is 'AMQ'
client, use _activemq.forced.delivery.seq, if it is 'HQ' use
_hornetq_forced.delivery.seq.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gaohoward/activemq-6 master_amq_64
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-6/pull/24.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #24
----
commit afe55861300d60eceeedd34eb95fe6a0da43ce4a
Author: Howard Gao <hg...@redhat.com>
Date: 2014-11-25T13:40:48Z
ACTIVEMQ6-42 Fix FORCED_DELIVERY_MESSAGE dependent on hornetq naming
When dealing with receiveNoWait messages, a special message with
a property called _activemq.forced.delivery.seq is being sent.
This property used to be _hornetq.forced.delivery.seq. In order
to be compatible with 'old' hornetq clients, this fix does the
following:
1. Determine the client type of a client during protocol handshake
phase of a connection. New clients will connect with a 'ACTIVEMQ'
and old clients will do with either 'HORNETQ' or nothing.
2. The clien types are identified by a new enum type ClientType.
It has two values 'AMQ' (new clients) and 'HQ' (old ones).
3. When a forced delivery is being sent, put a proper property
to the special message based on the client type. If it is 'AMQ'
client, use _activemq.forced.delivery.seq, if it is 'HQ' use
_hornetq_forced.delivery.seq.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-6 pull request: ACTIVEMQ6-42 Fix FORCED_DELIVERY_MESSAGE ...
Posted by gaohoward <gi...@git.apache.org>.
Github user gaohoward closed the pull request at:
https://github.com/apache/activemq-6/pull/24
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---