You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "mbien (via GitHub)" <gi...@apache.org> on 2023/03/21 17:12:13 UTC
[GitHub] [netbeans] mbien opened a new pull request, #5693: check maven version as workaround instead of embedded plugin version.
mbien opened a new pull request, #5693:
URL: https://github.com/apache/netbeans/pull/5693
The plugin version query returned the version of the embedded maven distribution instead of the active distribution. Since we can't do this easily, we can workaround this by comparing maven versions, since we can infer the plugin version from it.
Fixes the release version and the module-info hint.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5693: check maven version as workaround instead of embedded plugin version.
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #5693:
URL: https://github.com/apache/netbeans/pull/5693#issuecomment-1491139087
i made small changes to the comments to make them less confusing. Planning to merge once green again, thanks for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #5693: check maven version as workaround instead of embedded plugin version.
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #5693:
URL: https://github.com/apache/netbeans/pull/5693#issuecomment-1478610246
Nice idea. I think though, that I spotted a problem: Consider the situation where a new enough maven is present, but the compiler plugin is configured to an older version (for example because the project has $years of history). If I understand correctly, this might not be reported as an error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien merged pull request #5693: [maven hints] try to infer compiler plugin version from active maven version.
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien merged PR #5693:
URL: https://github.com/apache/netbeans/pull/5693
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5693: check maven version as workaround instead of embedded plugin version.
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #5693:
URL: https://github.com/apache/netbeans/pull/5693#issuecomment-1479196308
> If I understand correctly, this might not be reported as an error.
@matthiasblaesing agreed, we have to be especially careful with "false warnings".
Its just that while testing #5679 I noticed that some hints won't appear at all since the embedded version of NB would be very recent, other hints will try to add the compiler plugin despite it already being there with the required version.
Most of the maven editor support features only work properly right now if you leave the setting at "Bundled" and don't use a wrapper. This is a larger problem overall.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists