You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/11/12 21:34:09 UTC

[GitHub] [calcite-avatica] joshelser commented on a change in pull request #130: [CALCITE-4379] Meta.Frame created with java float values in rows hits a ClassCastException in toProto()

joshelser commented on a change in pull request #130:
URL: https://github.com/apache/calcite-avatica/pull/130#discussion_r522439536



##########
File path: core/src/test/java/org/apache/calcite/avatica/FrameTest.java
##########
@@ -105,6 +106,84 @@ public void testMultipleRows() {
     serializeAndTestEquality(singleRow);
   }
 
+  protected void testValueRoundTrip(Object value) {

Review comment:
       Can you please update `testSingleRow` in this class to also use this helper method you've created?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org