You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/15 13:55:06 UTC
[GitHub] [airflow] SPTKL opened a new pull request, #26418: specifying project id when calling wait_for_operation in delete/create cluster
SPTKL opened a new pull request, #26418:
URL: https://github.com/apache/airflow/pull/26418
closes: #26399
Given current set up, if default gcp project is `A` and we are trying to call `delete_cluster` or `create_cluster` with project `B`, we will perform the creation and delete in project `B` but `wait_for_operation` in the default project `A`.
This PR will pass project_id to `wait_for_operation`, so we are waiting operation to complete in the GCP project passed down by `delete_cluster` or `create_cluster`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #26418: specifying project id when calling wait_for_operation in delete/create cluster
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #26418:
URL: https://github.com/apache/airflow/pull/26418#issuecomment-1251969839
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #26418: specifying project id when calling wait_for_operation in delete/create cluster
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26418:
URL: https://github.com/apache/airflow/pull/26418#issuecomment-1250408200
I am afraid tests are failing (and it needs rebasing)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #26418: specifying project id when calling wait_for_operation in delete/create cluster
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #26418:
URL: https://github.com/apache/airflow/pull/26418
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #26418: specifying project id when calling wait_for_operation in delete/create cluster
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #26418:
URL: https://github.com/apache/airflow/pull/26418#issuecomment-1248136644
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org