You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2019/04/17 10:36:45 UTC
[Bug 63359] New: jsp:setProperty not spec compliant
https://bz.apache.org/bugzilla/show_bug.cgi?id=63359
Bug ID: 63359
Summary: jsp:setProperty not spec compliant
Product: Tomcat 9
Version: 9.0.x
Hardware: PC
OS: Linux
Status: NEW
Severity: normal
Priority: P2
Component: Jasper
Assignee: dev@tomcat.apache.org
Reporter: markt@apache.org
Target Milestone: -----
I came across this while reviewing the coverity scan results.
JSP.5.2 sets out <jsp:setProperty> should behave. That references JSP.1.14.2.1
for conversion from String values. Reviewing the code there appear to be
multiple related issues:
- PropertyEditor with null value may result in an exception when it should
always be null
- Empty strings are not correctly coerced
- Coercion to Object is to String[] rather than String
- Coercion to File is defined which is not present in the spec
Since this report originates from code inspection, test cases need to be
constructed to validate the bugs above before fixing. It would also be prudent
to run the full Tomcat test suite and the JSP TCK against any fix.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 63359] jsp:setProperty not spec compliant
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63359
--- Comment #1 from Mark Thomas <ma...@apache.org> ---
Both the TCK and the Tomcat test suite pass with all the fixes in place.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 63359] jsp:setProperty not spec compliant
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63359
Mark Thomas <ma...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
--- Comment #2 from Mark Thomas <ma...@apache.org> ---
Fixed in:
- master for 9.0.20 onwards
I don't propose back-porting this unless and until someone complains that 8.5.x
or 7.0.x isn't spec compliant. Given that this code has been wrong for well
over a decade, I'm not expecting any such reports.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org