You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@opendal.apache.org by "tottoto (via GitHub)" <gi...@apache.org> on 2023/05/10 08:43:49 UTC

[GitHub] [incubator-opendal] tottoto commented on a diff in pull request #2248: refactor: Replace futures with futures-util

tottoto commented on code in PR #2248:
URL: https://github.com/apache/incubator-opendal/pull/2248#discussion_r1189559459


##########
Cargo.lock:
##########
@@ -2538,7 +2538,7 @@ dependencies = [
  "chrono",
  "clap 4.2.5",
  "dirs 5.0.0",
- "futures",
+ "futures-util",

Review Comment:
   Makes sense. As core requires `futures-executor` at `services-sftp` feature, it's might be better to use `futures` and handle features to reduce costs to maintain dependencies.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org