You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "Rares Vernica (Jira)" <ji...@apache.org> on 2021/08/02 09:50:00 UTC

[jira] [Commented] (ARROW-13469) [C++] Suppress -Wmissing-field-initializers in DayMilliseconds arrow/type.h

    [ https://issues.apache.org/jira/browse/ARROW-13469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17391470#comment-17391470 ] 

Rares Vernica commented on ARROW-13469:
---------------------------------------

This is one of the files where I get the warning [https://github.com/Paradigm4/bridge/blob/11cc69f421bc88b8e183d55b1f906620a542e6a3/src/XIndex.cpp]

 
{noformat}
"/opt/rh/devtoolset-3/root/usr/bin/g++" -DARROW_NO_DEPRECATED_API -DNDEBUG -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -O3 -Wall -Wextra -Wno-long-long -Wno-strict-aliasing -Wno-system-headers -Wno-unused -Wno-unused-parameter -Wno-variadic-macros -fPIC -fno-omit-frame-pointer -g -std=c++14 -DAWS_COMMON_USE_IMPORT_EXPORT -DAWS_EVENT_STREAM_USE_IMPORT_EXPORT -DAWS_SDK_VERSION_MAJOR=1 -DAWS_SDK_VERSION_MINOR=8 -DAWS_SDK_VERSION_PATCH=3 -DPROJECT_ROOT="\"/opt/scidb/19.11\"" -I. -I"/opt/scidb/19.11/include" -I"/opt/scidb/19.11/3rdparty/boost/include" -I/opt/aws-sdk-cpp/include -I/opt/apache-arrow/include -c -o XIndex.o XIndex.cpp

In file included from /opt/apache-arrow/include/arrow/array/builder_dict.h:29:0,
 from /opt/apache-arrow/include/arrow/builder.h:26,
 from XIndex.cpp:38:
/opt/apache-arrow/include/arrow/array/builder_primitive.h: In instantiation of 'arrow::Status arrow::NumericBuilder<TypeClass>::AppendNull() [with T = arrow::DayTimeIntervalType]':
XIndex.cpp:430:1: required from here
/opt/apache-arrow/include/arrow/array/builder_primitive.h:102:5: warning: missing initializer for member 'arrow::DayTimeIntervalType::DayMilliseconds::days' [-Wmissing-field-initializers]
 data_builder_.UnsafeAppend(value_type{}); // zero
 ^
/opt/apache-arrow/include/arrow/array/builder_primitive.h:102:5: warning: missing initializer for member 'arrow::DayTimeIntervalType::DayMilliseconds::milliseconds' [-Wmissing-field-initializers]
/opt/apache-arrow/include/arrow/array/builder_primitive.h: In instantiation of 'arrow::Status arrow::NumericBuilder<TypeClass>::AppendNulls(int64_t) [with T = arrow::DayTimeIntervalType; int64_t = long int]':
XIndex.cpp:430:1: required from here
/opt/apache-arrow/include/arrow/array/builder_primitive.h:94:5: warning: missing initializer for member 'arrow::DayTimeIntervalType::DayMilliseconds::days' [-Wmissing-field-initializers]
 data_builder_.UnsafeAppend(length, value_type{}); // zero
 ^
/opt/apache-arrow/include/arrow/array/builder_primitive.h:94:5: warning: missing initializer for member 'arrow::DayTimeIntervalType::DayMilliseconds::milliseconds' [-Wmissing-field-initializers]
/opt/apache-arrow/include/arrow/array/builder_primitive.h: In instantiation of 'arrow::Status arrow::NumericBuilder<TypeClass>::AppendEmptyValue() [with T = arrow::DayTimeIntervalType]':
XIndex.cpp:430:1: required from here
/opt/apache-arrow/include/arrow/array/builder_primitive.h:110:5: warning: missing initializer for member 'arrow::DayTimeIntervalType::DayMilliseconds::days' [-Wmissing-field-initializers]
 data_builder_.UnsafeAppend(value_type{}); // zero
 ^
/opt/apache-arrow/include/arrow/array/builder_primitive.h:110:5: warning: missing initializer for member 'arrow::DayTimeIntervalType::DayMilliseconds::milliseconds' [-Wmissing-field-initializers]
/opt/apache-arrow/include/arrow/array/builder_primitive.h: In instantiation of 'arrow::Status arrow::NumericBuilder<TypeClass>::AppendEmptyValues(int64_t) [with T = arrow::DayTimeIntervalType; int64_t = long int]':
XIndex.cpp:430:1: required from here
/opt/apache-arrow/include/arrow/array/builder_primitive.h:118:5: warning: missing initializer for member 'arrow::DayTimeIntervalType::DayMilliseconds::days' [-Wmissing-field-initializers]
 data_builder_.UnsafeAppend(length, value_type{}); // zero
 ^
/opt/apache-arrow/include/arrow/array/builder_primitive.h:118:5: warning: missing initializer for member 'arrow::DayTimeIntervalType::DayMilliseconds::milliseconds' [-Wmissing-field-initializers] 
{noformat}
 

> [C++] Suppress -Wmissing-field-initializers in DayMilliseconds arrow/type.h
> ---------------------------------------------------------------------------
>
>                 Key: ARROW-13469
>                 URL: https://issues.apache.org/jira/browse/ARROW-13469
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: C++
>            Reporter: Wes McKinney
>            Assignee: Fernando Rodriguez
>            Priority: Major
>              Labels: beginner, pull-request-available
>             Fix For: 6.0.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> The absence of default values for {{days}} and {{milliseconds}} triggers a compiler warning in some compilers. This could be resolved by setting the struct member default values to 0
> see mailing list thread https://lists.apache.org/thread.html/r8b7dfdb456538dab57c533376cf1e9538cdbc84213e24f35cc5aaca3%40%3Cdev.arrow.apache.org%3E



--
This message was sent by Atlassian Jira
(v8.3.4#803005)