You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/07/28 22:53:34 UTC

[GitHub] [superset] rusackas commented on a change in pull request #15933: fix(dashboard): Show the filters popover behind the dashboard header when scrolling

rusackas commented on a change in pull request #15933:
URL: https://github.com/apache/superset/pull/15933#discussion_r678704554



##########
File path: superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx
##########
@@ -283,6 +285,13 @@ const DashboardBuilder: FC<DashboardBuilderProps> = () => {
         </DragDroppable>
       </StyledHeader>
       <StyledContent fullSizeChartId={fullSizeChartId}>
+        <Global
+          styles={css`

Review comment:
       I wonder if `styles` is any more performant than `css` or if we should just make this `css` for future consistency/themability. ¯\\\_(ツ)_/¯ 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org