[GitHub] [maven-shared-resources] gnodet edited a comment on pull request #1: [MSHARED-1033] Add resources required for automatic formatting and import sorting

[GitBox <gi...@apache.org>]

gnodet edited a comment on pull request #1:
URL: https://github.com/apache/maven-shared-resources/pull/1#issuecomment-1029448237


   > There is also references to IDE formaters on site: https://maven.apache.org/developers/conventions/code.html
   > 
   > Do we need some synchronization for its?
   > 
   > File is diferent: https://maven.apache.org/developers/maven-eclipse-codestyle.xml
   
   @slawekjaranowski 
   
   Yes, I would suggest that the web page should point to the GitHub file once it has been included, but I can raise a different PR for the website later.  
   
   As for the differences, those are really changes to make sure the automatic formatting complies with the checkstyle rules that are defined in the [maven_checks.xml](https://github.com/apache/maven-shared-resources/blob/master/src/main/resources/config/maven_checks.xml) file. This fixes alignment for various use cases to `16` (so not unsplit lines, alignment on the left...) so that long lines can be automatically reformatted.  I did try with the settings on the web site, but some lines can not be automatically formatted and comply with the checkstyle rules.  There are also missing settings from recent JDK  (lambda...)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org