You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@uniffle.apache.org by GitBox <gi...@apache.org> on 2023/01/18 09:37:37 UTC

[GitHub] [incubator-uniffle] zuston opened a new issue, #498: [Improvement] Extend event size threshold metric configuration to any number of levels

zuston opened a new issue, #498:
URL: https://github.com/apache/incubator-uniffle/issues/498

   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   
   
   ### Search before asking
   
   - [X] I have searched in the [issues](https://github.com/apache/incubator-uniffle/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### What would you like to be improved?
   
   In current codebase, it has three levels metrics of `rss.server.event.size.threshold.l1/l2/l3`, but this is not enough for production env. 
   
   We hope to extend event size threshold metric configuration to any number of levels, like introducing a new config option: 
   `rss.server.event.size.threshold.level.ranges=20k,1m,10m,100m,1g,10g,` which could cover the multiple levels for better configuring the writing threads number or single buffer flush size.
   
   ### How should we improve?
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-uniffle] zuston commented on issue #498: [Improvement] Extend event size threshold metric configuration to any number of levels

Posted by GitBox <gi...@apache.org>.
zuston commented on issue #498:
URL: https://github.com/apache/incubator-uniffle/issues/498#issuecomment-1396369309

   > So, you want to generate metric name dynamically, something like rss.server.event.size.threshold.{20k,1g}?
   
   Not accurate. Metrics will be exposed like: event_size_range_0_20k, event_size_range_20k_1m ....


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-uniffle] advancedxy commented on issue #498: [Improvement] Extend event size threshold metric configuration to any number of levels

Posted by GitBox <gi...@apache.org>.
advancedxy commented on issue #498:
URL: https://github.com/apache/incubator-uniffle/issues/498#issuecomment-1396367926

   > rss.server.event.size.threshold.level.ranges=20k,1m,10m,100m,1g,10g
   
   So, you want to generate metric name dynamically, something like `rss.server.event.size.threshold.{20k,1g}`? 
   I agree the fixed three level is limited and we should extend it. The problem is how much flexibility exposed to end user without confusing them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org