You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucy.apache.org by rectang <gi...@git.apache.org> on 2016/04/29 00:43:45 UTC
[lucy-dev] [GitHub] lucy pull request: LUCY-295 Adapt file position code for -Wconvers...
GitHub user rectang opened a pull request:
https://github.com/apache/lucy/pull/46
LUCY-295 Adapt file position code for -Wconversion
Perform casts or variable type conversions in code manipulating file positions in order to adapt for -Wconversion.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rectang/lucy LUCY-295-file-pos
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucy/pull/46.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #46
----
commit e629483e624bb6a701ff39b37ba7f4e09fd63140
Author: Marvin Humphrey <ma...@rectangular.com>
Date: 2016-04-28T00:57:55Z
Change `len` param to int64_t for internal read.
Use int64_t rather than size_t to make overflow checking easier.
commit e9afedbfdec345099cc47922ea4cabc34273dee7
Author: Marvin Humphrey <ma...@rectangular.com>
Date: 2016-04-28T22:08:36Z
Change internal size_t to int64_t in OutStream.
commit cc9a8169112df6989ec32d6c357ca63d0837773c
Author: Marvin Humphrey <ma...@rectangular.com>
Date: 2016-04-28T22:13:31Z
Cast or convert integers holding file positions.
Perform casts or change variable types to make code manipulating file
positions compliant with -Wconversion.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[lucy-dev] [GitHub] lucy pull request: LUCY-295 Adapt file position code for -Wconvers...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/lucy/pull/46
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---