You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2019/08/07 11:23:15 UTC

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #826: [HUDI-153] Use com.uber.hoodie.common.util.Option instead of Java and Guava Optional

vinothchandar commented on a change in pull request #826: [HUDI-153] Use com.uber.hoodie.common.util.Option instead of Java and Guava Optional
URL: https://github.com/apache/incubator-hudi/pull/826#discussion_r311497040
 
 

 ##########
 File path: hoodie-client/src/main/java/com/uber/hoodie/WriteStatus.java
 ##########
 @@ -73,7 +73,7 @@ public WriteStatus(Boolean trackSuccessRecords, Double failureFraction) {
    * @param optionalRecordMetadata optional metadata related to data contained in {@link
    * HoodieRecord} before deflation.
    */
-  public void markSuccess(HoodieRecord record, Optional<Map<String, String>> optionalRecordMetadata) {
+  public void markSuccess(HoodieRecord record, Option<Map<String, String>> optionalRecordMetadata) {
 
 Review comment:
   This is an API change that users need to be aware of @n3nash @bvaradar  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services