You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/04/02 20:47:57 UTC

[GitHub] [incubator-mxnet] anirudh2290 commented on a change in pull request #14570: [WIP] use a compile flag to use int64 tensor size

anirudh2290 commented on a change in pull request #14570: [WIP] use a compile flag to use int64 tensor size
URL: https://github.com/apache/incubator-mxnet/pull/14570#discussion_r271489370
 
 

 ##########
 File path: Makefile
 ##########
 @@ -188,6 +188,11 @@ ifeq ($(USE_OPERATOR_TUNING), 1)
 	CFLAGS += -DMXNET_USE_OPERATOR_TUNING=1
 endif
 
+ifeq ($(USE_INT64_TENSOR_SIZE), 1)
+   CFLAGS += -DMSHADOW_INT64_TENSOR_SIZE=1
 
 Review comment:
   Since USE_INT64_TENSOR_SIZE has been set by default to 0 this is a breaking change. Are we going to add an exception for semver for the next minor release ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services