You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by "Dapeng Sun (JIRA)" <ji...@apache.org> on 2016/06/21 03:01:57 UTC

[jira] [Resolved] (CRYPTO-85) CryptoCipher ENCRYPT_MODE and DECRYPT_MODE are unnecessary and confusing

     [ https://issues.apache.org/jira/browse/CRYPTO-85?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dapeng Sun resolved CRYPTO-85.
------------------------------
    Resolution: Fixed

Committed to master.

CRYPTO-85: CryptoCipher ENCRYPT_MODE and DECRYPT_MODE are unnecessary and confusing


Project: http://git-wip-us.apache.org/repos/asf/commons-crypto/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-crypto/commit/2c57b118
Tree: http://git-wip-us.apache.org/repos/asf/commons-crypto/tree/2c57b118
Diff: http://git-wip-us.apache.org/repos/asf/commons-crypto/diff/2c57b118


> CryptoCipher ENCRYPT_MODE and DECRYPT_MODE are unnecessary and confusing
> ------------------------------------------------------------------------
>
>                 Key: CRYPTO-85
>                 URL: https://issues.apache.org/jira/browse/CRYPTO-85
>             Project: Commons Crypto
>          Issue Type: Bug
>            Reporter: Sebb
>            Assignee: Dapeng Sun
>
> The CryptoCipher.ENCRYPT_MODE and DECRYPT_MODE constants don't seem to serve any purpose.
> They should be dropped and the javax.crypto.Cipher constants used instead.
> Alternatively, replace them with an enum, which would allow the compiler to check the values.
> Note: the values currently have to be checked by both JceCipher and OpensslCipher. Since JceCipher uses the Cipher constant that check would disappear if the CryptoCipher constant were dropped.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)