You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2019/01/30 02:20:15 UTC

[GitHub] duhenglucky commented on a change in pull request #733: [ISSUE #730]refactor Remoting module to support mqtt encode/decode and implement part of logic of mqtt CONNECT request

duhenglucky commented on a change in pull request #733: [ISSUE #730]refactor Remoting module to support mqtt encode/decode and implement part of logic of mqtt CONNECT request
URL: https://github.com/apache/rocketmq/pull/733#discussion_r252094403
 
 

 ##########
 File path: remoting/src/main/java/org/apache/rocketmq/remoting/protocol/RemotingCommand.java
 ##########
 @@ -174,6 +176,34 @@ public CommandCustomHeader decodeCommandCustomHeader(
         return CodecHelper.decodeCommandCustomHeader(this, classHeader);
     }
 
+    public void makeCustomHeaderToNet() {
 
 Review comment:
   Please use this  method  in CodecHelper class instead

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services