You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/04/28 08:34:38 UTC

[GitHub] [shardingsphere-elasticjob] seeger12138 opened a new pull request #1885: fix performance loss for the misfired configuration that is not turned on(#1883)

seeger12138 opened a new pull request #1885:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1885


   Fixes https://github.com/apache/shardingsphere-elasticjob/issues/1883
   
   Changes proposed in this pull request:
   - Reverse order !isNeedSharding() && configService.load(true).isMisfire() -> configService.load(true).isMisfire() && !isNeedSharding(). According to the short-circuit characteristics, if the misfired configuration is not turned on, there will be no additional performance loss.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere-elasticjob] TeslaCN merged pull request #1885: #1883 fix performance loss for the misfired configuration that is not turned on

Posted by GitBox <gi...@apache.org>.

TeslaCN merged pull request #1885:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1885


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org