[GitHub] [ignite] ivandasch commented on a diff in pull request #10740: IGNITE-15629 Cache clear/create/list commands implemented

["ivandasch (via GitHub)" <gi...@apache.org>]

ivandasch commented on code in PR #10740:
URL: https://github.com/apache/ignite/pull/10740#discussion_r1211155008


##########
modules/core/src/main/java/org/apache/ignite/internal/visor/verify/VisorViewCacheTask.java:
##########
@@ -18,45 +18,53 @@
 package org.apache.ignite.internal.visor.verify;
 
 import org.apache.ignite.IgniteException;
+import org.apache.ignite.internal.management.cache.CacheListCommandArg;
 import org.apache.ignite.internal.processors.cache.verify.ViewCacheClosure;
 import org.apache.ignite.internal.processors.task.GridInternal;
 import org.apache.ignite.internal.util.typedef.internal.S;
 import org.apache.ignite.internal.visor.VisorJob;
 import org.apache.ignite.internal.visor.VisorOneNodeTask;
 import org.jetbrains.annotations.Nullable;
+import static org.apache.ignite.internal.visor.verify.VisorViewCacheCmd.CACHES;
+import static org.apache.ignite.internal.visor.verify.VisorViewCacheCmd.GROUPS;
+import static org.apache.ignite.internal.visor.verify.VisorViewCacheCmd.SEQ;
 
 /**
  *
  */
 @GridInternal
-public class VisorViewCacheTask extends VisorOneNodeTask<VisorViewCacheTaskArg, VisorViewCacheTaskResult> {
+public class VisorViewCacheTask extends VisorOneNodeTask<CacheListCommandArg, VisorViewCacheTaskResult> {
     /** */
     private static final long serialVersionUID = 0L;
 
     /** {@inheritDoc} */
-    @Override protected VisorJob<VisorViewCacheTaskArg, VisorViewCacheTaskResult> job(VisorViewCacheTaskArg arg) {
+    @Override protected VisorJob<CacheListCommandArg, VisorViewCacheTaskResult> job(CacheListCommandArg arg) {
         return new VisorViewCacheJob(arg, debug);
     }
 
     /**
      *
      */
-    private static class VisorViewCacheJob extends VisorJob<VisorViewCacheTaskArg, VisorViewCacheTaskResult> {
+    private static class VisorViewCacheJob extends VisorJob<CacheListCommandArg, VisorViewCacheTaskResult> {
         /** */
         private static final long serialVersionUID = 0L;
 
         /**
          * @param arg Argument.
          * @param debug Debug.
          */
-        protected VisorViewCacheJob(@Nullable VisorViewCacheTaskArg arg, boolean debug) {
+        protected VisorViewCacheJob(@Nullable CacheListCommandArg arg, boolean debug) {
             super(arg, debug);
         }
 
         /** {@inheritDoc} */
-        @Override protected VisorViewCacheTaskResult run(@Nullable VisorViewCacheTaskArg arg) throws IgniteException {
+        @Override protected VisorViewCacheTaskResult run(@Nullable CacheListCommandArg arg) throws IgniteException {
             try {
-                ViewCacheClosure clo = new ViewCacheClosure(arg.regex(), arg.command());
+                VisorViewCacheCmd cmd = arg.groups()

Review Comment:
   The `arg` is nullable. Probably, it is required to add a null check?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org