You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Aias00 (via GitHub)" <gi...@apache.org> on 2026/07/31 12:31:48 UTC
[PR] [ISSUE #10724] Avoid raw gRPC response logs [rocketmq]
Aias00 opened a new pull request, #10725:
URL: https://github.com/apache/rocketmq/pull/10725
## Summary
- replace full gRPC response logging in ResponseWriter with a compact response summary
- include response type and protobuf status code when available
- add tests that verify receive-message payload bytes are not included in the summary
Fixes https://github.com/apache/rocketmq/issues/10724
## Tests
- JAVA_HOME=$(/usr/libexec/java_home -v 1.8) mvn -pl proxy -Dtest=ResponseWriterTest clean test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #10724] Avoid raw gRPC response logs [rocketmq]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #10725:
URL: https://github.com/apache/rocketmq/pull/10725#issuecomment-5143142505
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/10725?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `51.72414%` with `14 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.24%. Comparing base ([`00e45b8`](https://app.codecov.io/gh/apache/rocketmq/commit/00e45b8a6db23efbe756d0306f10716156cfd4dd?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7c32e8a`](https://app.codecov.io/gh/apache/rocketmq/commit/7c32e8afffb8fe2456546b36c63fc6742580933a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/rocketmq/pull/10725?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../rocketmq/proxy/grpc/v2/common/ResponseWriter.java](https://app.codecov.io/gh/apache/rocketmq/pull/10725?src=pr&el=tree&filepath=proxy%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fproxy%2Fgrpc%2Fv2%2Fcommon%2FResponseWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHJveHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Byb3h5L2dycGMvdjIvY29tbW9uL1Jlc3BvbnNlV3JpdGVyLmphdmE=) | 51.72% | [6 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/10725?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## develop #10725 +/- ##
=============================================
- Coverage 48.31% 48.24% -0.08%
+ Complexity 13511 13486 -25
=============================================
Files 1380 1380
Lines 101091 101117 +26
Branches 13101 13109 +8
=============================================
- Hits 48844 48780 -64
- Misses 46285 46347 +62
- Partials 5962 5990 +28
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/rocketmq/pull/10725?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #10724] Avoid raw gRPC response logs [rocketmq]
Posted by "Aias00 (via GitHub) via commits" <co...@rocketmq.apache.org>.
Aias00 closed pull request #10725: [ISSUE #10724] Avoid raw gRPC response logs
URL: https://github.com/apache/rocketmq/pull/10725
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org