Re: [PR] [ARTEMIS-6129] If a empty foreign MapMessage is send, map encoding is skipped [artemis]

["clebertsuconic (via GitHub)" <gi...@apache.org>]

clebertsuconic commented on code in PR #6540:
URL: https://github.com/apache/artemis/pull/6540#discussion_r3483096704


##########
tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/message/foreign/ForeignMapMessageTest.java:
##########
@@ -70,4 +78,18 @@ protected void assertEquivalent(final Message m, final int mode, final boolean r
       ProxyAssertSupport.assertEquals(map.getShort("short1"), (short) 5);
       ProxyAssertSupport.assertEquals(map.getString("string1"), "stringvalue");
    }
+
+   @Test
+   public void testSerializeEmptyForeignMapMessage() throws Exception {
+      ClientMessage clientMessage = new ClientMessageImpl(ActiveMQMapMessage.TYPE, true, 0, System.currentTimeMillis(), (byte) 4, 1000);
+      ClientSession session = new FakeSession(clientMessage);

Review Comment:
   Mockito.mock(ClientSession.class) would replace the whole class.
   
   We can amend it before merging it.  but if you want to do it. it would be great.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For additional commands, e-mail: issues-help@artemis.apache.org