[GitHub] [spark] stczwd commented on a change in pull request #28048: [SPARK-31142][PYSPARK]Remove useless conf set in pyspark context

[GitBox <gi...@apache.org>]

stczwd commented on a change in pull request #28048: [SPARK-31142][PYSPARK]Remove useless conf set in pyspark context
URL: https://github.com/apache/spark/pull/28048#discussion_r399774901
 
 

 ##########
 File path: python/pyspark/context.py
 ##########
 @@ -181,11 +181,6 @@ def _do_init(self, master, appName, sparkHome, pyFiles, environment, batchSize,
         self.appName = self._conf.get("spark.app.name")
         self.sparkHome = self._conf.get("spark.home", None)
 
-        for (k, v) in self._conf.getAll():
 
 Review comment:
   It seems like this is used to fix pyspark's tests, not really needed in actual environment. And this part of code is not to synchronize the configuration of the JVM, but to Ignore it.
   We did meet some problems here. The code here would overwrite the environment variables passed by the JVM, it is terrible especially when we optimized the environment variables in the JVM.
   I will see if there is any way to solve the test failure in [615fb64](https://github.com/apache/spark/commit/615fb649d66b13371927a051d249433d746c5f19). Even if there is no way, we should add the judgment and won't use it in actual environment.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org