You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by kostya-sh <gi...@git.apache.org> on 2015/05/11 14:49:56 UTC
[GitHub] thrift pull request: THRIFT-3144 go: do not include enum name in s...
GitHub user kostya-sh opened a pull request:
https://github.com/apache/thrift/pull/489
THRIFT-3144 go: do not include enum name in string representation
Changed generated String/FromString methods for enums to use values from thrift
definition file for string representation of an enum.
E.g.:
- before: String(TestEnum_FIRST) = "TestEnum_FIRST"
- after : String(TestEnum_FIRST) = "FIRST"
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kostya-sh/thrift THRIFT-3144
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/489.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #489
----
commit d0bc6079f9e308f5318e6d64482ac39462e3619c
Author: Konstantin Shaposhnikov <k....@gmail.com>
Date: 2015-05-11T12:44:05Z
THRIFT-3144 go: do not include enum name in string representation
Changed generated String/FromString methods for enums to use values from thrift
definition file for string representation of an enum.
E.g.:
- before: String(TestEnum_FIRST) = "TestEnum_FIRST"
- after : String(TestEnum_FIRST) = "FIRST"
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3144 go: do not include enum name in s...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/489
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---