You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Marton Greber (Code Review)" <ge...@cloudera.org> on 2023/05/25 07:12:41 UTC

[kudu-CR] KUDU-3479 Put some patches back into LLVM11

Marton Greber has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19933


Change subject: KUDU-3479 Put some patches back into LLVM11
......................................................................

KUDU-3479 Put some patches back into LLVM11

Commit fb6dc60621aa49f214b06d70527860c6a26c0e15 added two patches for
LLVM to fix build issue on Ubuntu 21.10. However, in commit
543e128d473f8f7836e605bba8cd6512fa918550 when I upgraded LLVM from 9 to
11, I forgot to chechk whether the previously added patches were
contained in the newer LLVM version. As it turns out not. This commit
backports those two patches for LLVM 11 and adds them back into the
build.

This issue came up during RHEL9 build experiments.

Change-Id: Ic7f9fa27aa1cde5e6ee93a87e536e71b20a67785
---
M thirdparty/download-thirdparty.sh
M thirdparty/patches/llvm-remove-cyclades-inclusion-in-sanitizer.patch
2 files changed, 36 insertions(+), 34 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/19933/1
-- 
To view, visit http://gerrit.cloudera.org:8080/19933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic7f9fa27aa1cde5e6ee93a87e536e71b20a67785
Gerrit-Change-Number: 19933
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>

[kudu-CR] KUDU-3479 Put some patches back into LLVM 11

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19933 )

Change subject: KUDU-3479 Put some patches back into LLVM 11
......................................................................

KUDU-3479 Put some patches back into LLVM 11

Commit fb6dc60621aa49f214b06d70527860c6a26c0e15 added two patches for
LLVM to fix build issue on Ubuntu 21.10. However, in commit
543e128d473f8f7836e605bba8cd6512fa918550 when I upgraded LLVM from 9 to
11, I forgot to check whether the previously added patches were
contained in the newer LLVM version. As it turns out not. This commit
backports those two patches for LLVM 11 and adds them back into the
build.

This issue came up during RHEL9 build experiments.

Change-Id: Ic7f9fa27aa1cde5e6ee93a87e536e71b20a67785
Reviewed-on: http://gerrit.cloudera.org:8080/19933
Tested-by: Kudu Jenkins
Reviewed-by: Zoltan Chovan <zc...@cloudera.com>
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M thirdparty/download-thirdparty.sh
M thirdparty/patches/llvm-remove-cyclades-inclusion-in-sanitizer.patch
2 files changed, 36 insertions(+), 34 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Zoltan Chovan: Looks good to me, but someone else must approve
  Alexey Serbin: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/19933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic7f9fa27aa1cde5e6ee93a87e536e71b20a67785
Gerrit-Change-Number: 19933
Gerrit-PatchSet: 4
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>

[kudu-CR] KUDU-3479 Put some patches back into LLVM 11

Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/19933 )

Change subject: KUDU-3479 Put some patches back into LLVM 11
......................................................................


Patch Set 3: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/19933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7f9fa27aa1cde5e6ee93a87e536e71b20a67785
Gerrit-Change-Number: 19933
Gerrit-PatchSet: 3
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 30 May 2023 10:34:09 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-3479 Put some patches back into LLVM 11

Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/19933 )

Change subject: KUDU-3479 Put some patches back into LLVM 11
......................................................................


Patch Set 2: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/19933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7f9fa27aa1cde5e6ee93a87e536e71b20a67785
Gerrit-Change-Number: 19933
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 May 2023 10:23:03 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-3479 Put some patches back into LLVM 11

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/19933 )

Change subject: KUDU-3479 Put some patches back into LLVM 11
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19933/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/19933/2//COMMIT_MSG@12
PS2, Line 12: check 
> check
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/19933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7f9fa27aa1cde5e6ee93a87e536e71b20a67785
Gerrit-Change-Number: 19933
Gerrit-PatchSet: 3
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 30 May 2023 08:57:59 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-3479 Put some patches back into LLVM 11

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19933 )

Change subject: KUDU-3479 Put some patches back into LLVM 11
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19933/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/19933/2//COMMIT_MSG@12
PS2, Line 12: chechk
check



-- 
To view, visit http://gerrit.cloudera.org:8080/19933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7f9fa27aa1cde5e6ee93a87e536e71b20a67785
Gerrit-Change-Number: 19933
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 May 2023 21:42:06 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-3479 Put some patches back into LLVM 11

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19933

to look at the new patch set (#2).

Change subject: KUDU-3479 Put some patches back into LLVM 11
......................................................................

KUDU-3479 Put some patches back into LLVM 11

Commit fb6dc60621aa49f214b06d70527860c6a26c0e15 added two patches for
LLVM to fix build issue on Ubuntu 21.10. However, in commit
543e128d473f8f7836e605bba8cd6512fa918550 when I upgraded LLVM from 9 to
11, I forgot to chechk whether the previously added patches were
contained in the newer LLVM version. As it turns out not. This commit
backports those two patches for LLVM 11 and adds them back into the
build.

This issue came up during RHEL9 build experiments.

Change-Id: Ic7f9fa27aa1cde5e6ee93a87e536e71b20a67785
---
M thirdparty/download-thirdparty.sh
M thirdparty/patches/llvm-remove-cyclades-inclusion-in-sanitizer.patch
2 files changed, 36 insertions(+), 34 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/19933/2
-- 
To view, visit http://gerrit.cloudera.org:8080/19933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic7f9fa27aa1cde5e6ee93a87e536e71b20a67785
Gerrit-Change-Number: 19933
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] KUDU-3479 Put some patches back into LLVM 11

Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Chovan, Alexey Serbin, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19933

to look at the new patch set (#3).

Change subject: KUDU-3479 Put some patches back into LLVM 11
......................................................................

KUDU-3479 Put some patches back into LLVM 11

Commit fb6dc60621aa49f214b06d70527860c6a26c0e15 added two patches for
LLVM to fix build issue on Ubuntu 21.10. However, in commit
543e128d473f8f7836e605bba8cd6512fa918550 when I upgraded LLVM from 9 to
11, I forgot to check whether the previously added patches were
contained in the newer LLVM version. As it turns out not. This commit
backports those two patches for LLVM 11 and adds them back into the
build.

This issue came up during RHEL9 build experiments.

Change-Id: Ic7f9fa27aa1cde5e6ee93a87e536e71b20a67785
---
M thirdparty/download-thirdparty.sh
M thirdparty/patches/llvm-remove-cyclades-inclusion-in-sanitizer.patch
2 files changed, 36 insertions(+), 34 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/19933/3
-- 
To view, visit http://gerrit.cloudera.org:8080/19933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic7f9fa27aa1cde5e6ee93a87e536e71b20a67785
Gerrit-Change-Number: 19933
Gerrit-PatchSet: 3
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>

[kudu-CR] KUDU-3479 Put some patches back into LLVM 11

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19933 )

Change subject: KUDU-3479 Put some patches back into LLVM 11
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/19933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7f9fa27aa1cde5e6ee93a87e536e71b20a67785
Gerrit-Change-Number: 19933
Gerrit-PatchSet: 3
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 30 May 2023 18:22:51 +0000
Gerrit-HasComments: No