You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by GitBox <gi...@apache.org> on 2022/07/08 10:54:36 UTC
[GitHub] [incubator-uniffle] zuston opened a new pull request, #42: Introduce the reservedData to extend more pluggable accessCheckers
zuston opened a new pull request, #42:
URL: https://github.com/apache/incubator-uniffle/pull/42
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://github.com/Tencent/Firestorm/blob/master/CONTRIBUTING.md
2. Ensure you have added or run the appropriate tests for your PR
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]XXXX Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
Introduce the reservedData to extend more pluggable accessCheckers
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
In current codebase, the accessinfo only have acessid and tags. If we want to extend more AccessChecker in coordinator, the info is not enough.
To solve this, i think introducing the reservedData is necessary.
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
No.
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
UTs
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #42: Introduce the reservedData to extend more pluggable accessCheckers
Posted by GitBox <gi...@apache.org>.
jerqi commented on PR #42:
URL: https://github.com/apache/incubator-uniffle/pull/42#issuecomment-1186117256
> I think it's an incompatible change.
I think we can make it become a compatible feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #42: Introduce the reservedData to extend more pluggable accessCheckers
Posted by GitBox <gi...@apache.org>.
jerqi commented on PR #42:
URL: https://github.com/apache/incubator-uniffle/pull/42#issuecomment-1186104336
Is this a compatible feature? Can low version client use high version client? Can high version client use low version client?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #42: Introduce the reservedData to extend more pluggable accessCheckers
Posted by GitBox <gi...@apache.org>.
jerqi commented on code in PR #42:
URL: https://github.com/apache/incubator-uniffle/pull/42#discussion_r922766004
##########
coordinator/src/main/java/org/apache/uniffle/coordinator/CoordinatorGrpcService.java:
##########
@@ -206,7 +207,10 @@ public void accessCluster(AccessClusterRequest request, StreamObserver<AccessClu
AccessClusterResponse response;
AccessManager accessManager = coordinatorServer.getAccessManager();
- AccessInfo accessInfo = new AccessInfo(request.getAccessId(), Sets.newHashSet(request.getTagsList()));
+ Map<String, String> extraProperties = request.getExtraPropertiesMap();
+ AccessInfo accessInfo =
+ new AccessInfo(request.getAccessId(), Sets.newHashSet(request.getTagsList()),
+ extraProperties == null ? Collections.emptyMap() : extraProperties);
Review Comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] duanmeng merged pull request #42: Introduce the extraProperties to support user-defined pluggable accessCheckers
Posted by GitBox <gi...@apache.org>.
duanmeng merged PR #42:
URL: https://github.com/apache/incubator-uniffle/pull/42
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on pull request #42: Introduce the reservedData to extend more pluggable accessCheckers
Posted by GitBox <gi...@apache.org>.
zuston commented on PR #42:
URL: https://github.com/apache/incubator-uniffle/pull/42#issuecomment-1186107292
I think it's an incompatible change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] codecov-commenter commented on pull request #42: Introduce the reservedData to extend more pluggable accessCheckers
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #42:
URL: https://github.com/apache/incubator-uniffle/pull/42#issuecomment-1186070950
# [Codecov](https://codecov.io/gh/apache/incubator-uniffle/pull/42?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#42](https://codecov.io/gh/apache/incubator-uniffle/pull/42?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a028f75) into [master](https://codecov.io/gh/apache/incubator-uniffle/commit/f4ce2edd2d4e3355a6f1e12f0e7f712964fe83b4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f4ce2ed) will **decrease** coverage by `1.08%`.
> The diff coverage is `42.85%`.
```diff
@@ Coverage Diff @@
## master #42 +/- ##
============================================
- Coverage 55.21% 54.12% -1.09%
+ Complexity 1111 1035 -76
============================================
Files 148 139 -9
Lines 7953 7582 -371
Branches 760 730 -30
============================================
- Hits 4391 4104 -287
+ Misses 3321 3245 -76
+ Partials 241 233 -8
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-uniffle/pull/42?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...he/uniffle/coordinator/CoordinatorGrpcService.java](https://codecov.io/gh/apache/incubator-uniffle/pull/42/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29vcmRpbmF0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3VuaWZmbGUvY29vcmRpbmF0b3IvQ29vcmRpbmF0b3JHcnBjU2VydmljZS5qYXZh) | `2.43% <0.00%> (-0.04%)` | :arrow_down: |
| [...ava/org/apache/uniffle/coordinator/AccessInfo.java](https://codecov.io/gh/apache/incubator-uniffle/pull/42/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29vcmRpbmF0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3VuaWZmbGUvY29vcmRpbmF0b3IvQWNjZXNzSW5mby5qYXZh) | `90.90% <75.00%> (-9.10%)` | :arrow_down: |
| [.../java/org/apache/uniffle/server/ShuffleServer.java](https://codecov.io/gh/apache/incubator-uniffle/pull/42/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL3NlcnZlci9TaHVmZmxlU2VydmVyLmphdmE=) | `61.34% <0.00%> (-3.37%)` | :arrow_down: |
| [...storage/handler/impl/DataSkippableReadHandler.java](https://codecov.io/gh/apache/incubator-uniffle/pull/42/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmFnZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdW5pZmZsZS9zdG9yYWdlL2hhbmRsZXIvaW1wbC9EYXRhU2tpcHBhYmxlUmVhZEhhbmRsZXIuamF2YQ==) | `81.25% <0.00%> (-3.13%)` | :arrow_down: |
| [...org/apache/uniffle/server/ShuffleFlushManager.java](https://codecov.io/gh/apache/incubator-uniffle/pull/42/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL3NlcnZlci9TaHVmZmxlRmx1c2hNYW5hZ2VyLmphdmE=) | `76.70% <0.00%> (-1.71%)` | :arrow_down: |
| [...e/uniffle/server/storage/SingleStorageManager.java](https://codecov.io/gh/apache/incubator-uniffle/pull/42/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL3NlcnZlci9zdG9yYWdlL1NpbmdsZVN0b3JhZ2VNYW5hZ2VyLmphdmE=) | `65.57% <0.00%> (-1.64%)` | :arrow_down: |
| [.../apache/uniffle/coordinator/ClientConfManager.java](https://codecov.io/gh/apache/incubator-uniffle/pull/42/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29vcmRpbmF0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3VuaWZmbGUvY29vcmRpbmF0b3IvQ2xpZW50Q29uZk1hbmFnZXIuamF2YQ==) | `91.54% <0.00%> (-1.41%)` | :arrow_down: |
| [...k/shuffle/writer/WrappedByteArrayOutputStream.java](https://codecov.io/gh/apache/incubator-uniffle/pull/42/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LXNwYXJrL2NvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc3Bhcmsvc2h1ZmZsZS93cml0ZXIvV3JhcHBlZEJ5dGVBcnJheU91dHB1dFN0cmVhbS5qYXZh) | | |
| [...org/apache/spark/shuffle/writer/AddBlockEvent.java](https://codecov.io/gh/apache/incubator-uniffle/pull/42/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LXNwYXJrL2NvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc3Bhcmsvc2h1ZmZsZS93cml0ZXIvQWRkQmxvY2tFdmVudC5qYXZh) | | |
| [...ava/org/apache/spark/shuffle/RssShuffleHandle.java](https://codecov.io/gh/apache/incubator-uniffle/pull/42/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LXNwYXJrL2NvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc3Bhcmsvc2h1ZmZsZS9Sc3NTaHVmZmxlSGFuZGxlLmphdmE=) | | |
| ... and [6 more](https://codecov.io/gh/apache/incubator-uniffle/pull/42/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-uniffle/pull/42?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-uniffle/pull/42?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f4ce2ed...a028f75](https://codecov.io/gh/apache/incubator-uniffle/pull/42?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #42: Introduce the reservedData to extend more pluggable accessCheckers
Posted by GitBox <gi...@apache.org>.
jerqi commented on code in PR #42:
URL: https://github.com/apache/incubator-uniffle/pull/42#discussion_r922763154
##########
coordinator/src/main/java/org/apache/uniffle/coordinator/CoordinatorGrpcService.java:
##########
@@ -206,7 +207,10 @@ public void accessCluster(AccessClusterRequest request, StreamObserver<AccessClu
AccessClusterResponse response;
AccessManager accessManager = coordinatorServer.getAccessManager();
- AccessInfo accessInfo = new AccessInfo(request.getAccessId(), Sets.newHashSet(request.getTagsList()));
+ Map<String, String> extraProperties = request.getExtraPropertiesMap();
+ AccessInfo accessInfo =
+ new AccessInfo(request.getAccessId(), Sets.newHashSet(request.getTagsList()),
+ extraProperties == null ? Collections.emptyMap() : extraProperties);
Review Comment:
Why don't we use method `hasExtraPropertiesMap()`? If request' don't have member, it will give it a default value, the default value may not be null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on a diff in pull request #42: Introduce the reservedData to extend more pluggable accessCheckers
Posted by GitBox <gi...@apache.org>.
zuston commented on code in PR #42:
URL: https://github.com/apache/incubator-uniffle/pull/42#discussion_r922764244
##########
coordinator/src/main/java/org/apache/uniffle/coordinator/CoordinatorGrpcService.java:
##########
@@ -206,7 +207,10 @@ public void accessCluster(AccessClusterRequest request, StreamObserver<AccessClu
AccessClusterResponse response;
AccessManager accessManager = coordinatorServer.getAccessManager();
- AccessInfo accessInfo = new AccessInfo(request.getAccessId(), Sets.newHashSet(request.getTagsList()));
+ Map<String, String> extraProperties = request.getExtraPropertiesMap();
+ AccessInfo accessInfo =
+ new AccessInfo(request.getAccessId(), Sets.newHashSet(request.getTagsList()),
+ extraProperties == null ? Collections.emptyMap() : extraProperties);
Review Comment:
Proto2 has this method but proto3 don’t have this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] duanmeng commented on a diff in pull request #42: Introduce the reservedData to extend more pluggable accessCheckers
Posted by GitBox <gi...@apache.org>.
duanmeng commented on code in PR #42:
URL: https://github.com/apache/incubator-uniffle/pull/42#discussion_r922947393
##########
coordinator/src/main/java/org/apache/uniffle/coordinator/CoordinatorGrpcService.java:
##########
@@ -206,7 +207,10 @@ public void accessCluster(AccessClusterRequest request, StreamObserver<AccessClu
AccessClusterResponse response;
AccessManager accessManager = coordinatorServer.getAccessManager();
- AccessInfo accessInfo = new AccessInfo(request.getAccessId(), Sets.newHashSet(request.getTagsList()));
+ Map<String, String> extraProperties = request.getExtraPropertiesMap();
+ AccessInfo accessInfo =
+ new AccessInfo(request.getAccessId(), Sets.newHashSet(request.getTagsList()),
+ extraProperties == null ? Collections.emptyMap() : extraProperties);
Review Comment:
It'd be better to let the `AccessInfo` handle the case where the parameter `extraProperties` is null in its constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #42: Introduce the reservedData to extend more pluggable accessCheckers
Posted by GitBox <gi...@apache.org>.
jerqi commented on PR #42:
URL: https://github.com/apache/incubator-uniffle/pull/42#issuecomment-1186391848
LGTM, let @duanmeng take a look and decide whether to approve.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on a diff in pull request #42: Introduce the reservedData to extend more pluggable accessCheckers
Posted by GitBox <gi...@apache.org>.
zuston commented on code in PR #42:
URL: https://github.com/apache/incubator-uniffle/pull/42#discussion_r922995926
##########
coordinator/src/main/java/org/apache/uniffle/coordinator/CoordinatorGrpcService.java:
##########
@@ -206,7 +207,10 @@ public void accessCluster(AccessClusterRequest request, StreamObserver<AccessClu
AccessClusterResponse response;
AccessManager accessManager = coordinatorServer.getAccessManager();
- AccessInfo accessInfo = new AccessInfo(request.getAccessId(), Sets.newHashSet(request.getTagsList()));
+ Map<String, String> extraProperties = request.getExtraPropertiesMap();
+ AccessInfo accessInfo =
+ new AccessInfo(request.getAccessId(), Sets.newHashSet(request.getTagsList()),
+ extraProperties == null ? Collections.emptyMap() : extraProperties);
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on a diff in pull request #42: Introduce the reservedData to extend more pluggable accessCheckers
Posted by GitBox <gi...@apache.org>.
zuston commented on code in PR #42:
URL: https://github.com/apache/incubator-uniffle/pull/42#discussion_r922993683
##########
internal-client/src/main/java/org/apache/uniffle/client/request/RssAccessClusterRequest.java:
##########
@@ -17,18 +17,34 @@
package org.apache.uniffle.client.request;
+import java.util.Collections;
+import java.util.Map;
import java.util.Set;
public class RssAccessClusterRequest {
private final String accessId;
private final Set<String> tags;
private final int timeoutMs;
+ /**
+ * The map is to pass the extra data to the coordinator and to
+ * extend more pluggable {@code AccessCheckers} easily.
+ */
+ private final Map<String, String> extraProperties;
public RssAccessClusterRequest(String accessId, Set<String> tags, int timeoutMs) {
this.accessId = accessId;
this.tags = tags;
this.timeoutMs = timeoutMs;
+ this.extraProperties = Collections.emptyMap();
+ }
+
+ public RssAccessClusterRequest(String accessId, Set<String> tags, int timeoutMs,
+ Map<String, String> extraProperties) {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] duanmeng commented on a diff in pull request #42: Introduce the reservedData to extend more pluggable accessCheckers
Posted by GitBox <gi...@apache.org>.
duanmeng commented on code in PR #42:
URL: https://github.com/apache/incubator-uniffle/pull/42#discussion_r922945404
##########
internal-client/src/main/java/org/apache/uniffle/client/request/RssAccessClusterRequest.java:
##########
@@ -17,18 +17,34 @@
package org.apache.uniffle.client.request;
+import java.util.Collections;
+import java.util.Map;
import java.util.Set;
public class RssAccessClusterRequest {
private final String accessId;
private final Set<String> tags;
private final int timeoutMs;
+ /**
+ * The map is to pass the extra data to the coordinator and to
+ * extend more pluggable {@code AccessCheckers} easily.
+ */
+ private final Map<String, String> extraProperties;
public RssAccessClusterRequest(String accessId, Set<String> tags, int timeoutMs) {
this.accessId = accessId;
this.tags = tags;
this.timeoutMs = timeoutMs;
+ this.extraProperties = Collections.emptyMap();
+ }
+
+ public RssAccessClusterRequest(String accessId, Set<String> tags, int timeoutMs,
+ Map<String, String> extraProperties) {
Review Comment:
Either all parameters on the next line or one new line per parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on pull request #42: Introduce the reservedData to extend more pluggable accessCheckers
Posted by GitBox <gi...@apache.org>.
zuston commented on PR #42:
URL: https://github.com/apache/incubator-uniffle/pull/42#issuecomment-1186071614
@duanmeng @jerqi Updated
Changelog
1. Rename the reservedData to extraProperties
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #42: Introduce the reservedData to extend more pluggable accessCheckers
Posted by GitBox <gi...@apache.org>.
jerqi commented on PR #42:
URL: https://github.com/apache/incubator-uniffle/pull/42#issuecomment-1178887921
Could you give us some examples?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on pull request #42: Introduce the reservedData to extend more pluggable accessCheckers
Posted by GitBox <gi...@apache.org>.
zuston commented on PR #42:
URL: https://github.com/apache/incubator-uniffle/pull/42#issuecomment-1186382850
@jerqi
Tested. Now if the client of low version is interactive with high version coordinator, the current implementation is compatible.
The extraProperties will be a unmodified empty map.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on pull request #42: Introduce the reservedData to extend more pluggable accessCheckers
Posted by GitBox <gi...@apache.org>.
zuston commented on PR #42:
URL: https://github.com/apache/incubator-uniffle/pull/42#issuecomment-1181165045
Could u help check this PR? @duanmeng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] duanmeng commented on a diff in pull request #42: Introduce the reservedData to extend more pluggable accessCheckers
Posted by GitBox <gi...@apache.org>.
duanmeng commented on code in PR #42:
URL: https://github.com/apache/incubator-uniffle/pull/42#discussion_r918832031
##########
proto/src/main/proto/Rss.proto:
##########
@@ -335,6 +335,7 @@ message CheckServiceAvailableResponse {
message AccessClusterRequest {
string accessId = 1;
repeated string tags = 2;
+ map<string, string> reservedData = 3;
Review Comment:
could we use the name `extraProperties`, or another more suitable name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on a diff in pull request #42: Introduce the reservedData to extend more pluggable accessCheckers
Posted by GitBox <gi...@apache.org>.
zuston commented on code in PR #42:
URL: https://github.com/apache/incubator-uniffle/pull/42#discussion_r918886079
##########
proto/src/main/proto/Rss.proto:
##########
@@ -335,6 +335,7 @@ message CheckServiceAvailableResponse {
message AccessClusterRequest {
string accessId = 1;
repeated string tags = 2;
+ map<string, string> reservedData = 3;
Review Comment:
extraProperties is ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org