You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cassandra.apache.org by Javier Canillas <ja...@gmail.com> on 2018/03/09 16:19:59 UTC
Re: CREATE INDEX without IF NOT EXISTS when snapshoting
Guys,
Hope you are all doing fine. Is there any news about this trivial issue
<https://issues.apache.org/jira/browse/CASSANDRA-13935>? Are you
considering to include it in next release? Or there is something I should
do?
Thanks!
Javier.
2017-10-05 10:41 GMT-03:00 Javier Canillas <ja...@gmail.com>:
> Well,
>
> Patches submitted for version 3.0, 3.11 and trunk (although 3.0 patch can
> be applied to 3.11). Feel free to review and comment.
>
> Thanks!
>
> 2017-10-04 16:41 GMT-03:00 Javier Canillas <ja...@gmail.com>:
>
>> Kurt,
>>
>> Thanks for your response. Created this ticket
>> <https://issues.apache.org/jira/browse/CASSANDRA-13935>. Feel free to
>> add anything to it that seems legit.
>>
>> Downloading Cassandra code right now.
>>
>> Fix seems quite simple. Expect a pull-request soon xD
>>
>> 2017-10-03 20:19 GMT-03:00 kurt greaves <ku...@instaclustr.com>:
>>
>>> Certainly would make sense and should be trivial. here
>>> <https://github.com/apache/cassandra/blob/982ab93a2f8a0f5c56af9378f65d3e9e430000b9/src/java/org/apache/cassandra/db/ColumnFamilyStoreCQLHelper.java#L251> is
>>> where you want to look. Just create a ticket for it and prod here for a
>>> reviewer once you've got a change.
>>>
>>
>>
>
Re: CREATE INDEX without IF NOT EXISTS when snapshoting
Posted by Michael Shuler <mi...@pbandjelly.org>.
Double check your patches apply cleanly to the current branch HEADs,
since they are a few months old (CHANGES.txt conflicts and any others
you find) and update patches.
You're doing the right thing asking for a reviewer/committer to get a
little attention. Conflict-free patches help that person. It does look
like a pretty simple change, so keep asking. Bonus points for circle-ci
tests completed, etc. :)
--
Kind regards,
Michael
On 03/09/2018 10:19 AM, Javier Canillas wrote:
> Guys,
>
> Hope you are all doing fine. Is there any news about this trivial issue
> <https://issues.apache.org/jira/browse/CASSANDRA-13935>? Are you
> considering to include it in next release? Or there is something I should
> do?
>
> Thanks!
>
> Javier.
>
> 2017-10-05 10:41 GMT-03:00 Javier Canillas <ja...@gmail.com>:
>
>> Well,
>>
>> Patches submitted for version 3.0, 3.11 and trunk (although 3.0 patch can
>> be applied to 3.11). Feel free to review and comment.
>>
>> Thanks!
>>
>> 2017-10-04 16:41 GMT-03:00 Javier Canillas <ja...@gmail.com>:
>>
>>> Kurt,
>>>
>>> Thanks for your response. Created this ticket
>>> <https://issues.apache.org/jira/browse/CASSANDRA-13935>. Feel free to
>>> add anything to it that seems legit.
>>>
>>> Downloading Cassandra code right now.
>>>
>>> Fix seems quite simple. Expect a pull-request soon xD
>>>
>>> 2017-10-03 20:19 GMT-03:00 kurt greaves <ku...@instaclustr.com>:
>>>
>>>> Certainly would make sense and should be trivial. here
>>>> <https://github.com/apache/cassandra/blob/982ab93a2f8a0f5c56af9378f65d3e9e430000b9/src/java/org/apache/cassandra/db/ColumnFamilyStoreCQLHelper.java#L251> is
>>>> where you want to look. Just create a ticket for it and prod here for a
>>>> reviewer once you've got a change.
>>>>
>>>
>>>
>>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
For additional commands, e-mail: dev-help@cassandra.apache.org