You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/10/12 06:39:52 UTC
[GitHub] [incubator-eventmesh] anubhav823 opened a new pull request, #1531: Removed redundant null check as per issue #1009
anubhav823 opened a new pull request, #1531:
URL: https://github.com/apache/incubator-eventmesh/pull/1531
<!--
### Contribution Checklist
- Name the pull request in the form "[ISSUE #XXXX] Title of the pull request",
where *XXXX* should be replaced by the actual issue number.
Skip *[ISSUE #XXXX]* if there is no associated github issue for this pull request.
- Fill out the template below to describe the changes contributed by the pull request.
That will give reviewers the context they need to do the review.
- Each pull request should address only one issue.
Please do not mix up code from multiple issues.
- Each commit in the pull request should have a meaningful commit message.
- Once all items of the checklist are addressed, remove the above text and this checklist,
leaving only the filled out template below.
(The sections below can be removed for hotfixes of typos)
-->
<!--
(If this PR fixes a GitHub issue, please add `Fixes #<XXX>` or `Cloese #<XXX>`.)
-->
Fixes #1009 .
### Motivation
*Explain the content here.*
*Explain why you want to make the changes and what problem you're trying to solve.*
The null check is redundant and hence I removed it and raised a PR
### Modifications
*Describe the modifications you've done.*
I removed a redundant null check from the code.
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] anubhav823 commented on pull request #1531: [ISSUE #1009]Removed redundant null check as per issue #1009
Posted by GitBox <gi...@apache.org>.
anubhav823 commented on PR #1531:
URL: https://github.com/apache/incubator-eventmesh/pull/1531#issuecomment-1277641707
Hi @qqeasonchen
Is it possible to add a Hacktoberfest label to this PR? Seems like this PR is not being counted for my contributions for Hacktoberfest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] qqeasonchen commented on pull request #1531: [ISSUE #1009]Removed redundant null check as per issue #1009
Posted by GitBox <gi...@apache.org>.
qqeasonchen commented on PR #1531:
URL: https://github.com/apache/incubator-eventmesh/pull/1531#issuecomment-1278425834
> Hi @qqeasonchen
>
> Is it possible to add a Hacktoberfest label to this PR? Seems like this PR is not being counted for my contributions for Hacktoberfest.
sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] anubhav823 commented on pull request #1531: [ISSUE #1009]Removed redundant null check as per issue #1009
Posted by GitBox <gi...@apache.org>.
anubhav823 commented on PR #1531:
URL: https://github.com/apache/incubator-eventmesh/pull/1531#issuecomment-1278429297
Awesome! Please let me know if anything is needed from my end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] qqeasonchen merged pull request #1531: [ISSUE #1009]Removed redundant null check as per issue #1009
Posted by GitBox <gi...@apache.org>.
qqeasonchen merged PR #1531:
URL: https://github.com/apache/incubator-eventmesh/pull/1531
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org