[GitHub] mistercrunch closed pull request #2456: use full name for data sources

[GitBox <gi...@apache.org>]

mistercrunch closed pull request #2456: use full name for data sources
URL: https://github.com/apache/incubator-superset/pull/2456
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/superset/connectors/druid/models.py b/superset/connectors/druid/models.py
index 4ad6a6f951..195f6480d3 100644
--- a/superset/connectors/druid/models.py
+++ b/superset/connectors/druid/models.py
@@ -391,7 +391,7 @@ def time_column_grains(self):
         }
 
     def __repr__(self):
-        return self.datasource_name
+        return self.full_name
 
     @renders('datasource_name')
     def datasource_link(self):
diff --git a/superset/connectors/sqla/models.py b/superset/connectors/sqla/models.py
index 913ee59579..6c74e4ff4b 100644
--- a/superset/connectors/sqla/models.py
+++ b/superset/connectors/sqla/models.py
@@ -196,7 +196,7 @@ class SqlaTable(Model, BaseDatasource):
             name='_customer_location_uc'),)
 
     def __repr__(self):
-        return self.name
+        return self.full_name
 
     @property
     def description_markeddown(self):


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services