You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by cs...@apache.org on 2021/05/21 08:09:24 UTC

[maven-shade-plugin] 01/01: Fix for Java16+

This is an automated email from the ASF dual-hosted git repository.

cstamas pushed a commit to branch fix-java16
in repository https://gitbox.apache.org/repos/asf/maven-shade-plugin.git

commit 56785aa559870ff0906de8937198fb21178eea75
Author: Tamas Cservenak <ta...@cservenak.net>
AuthorDate: Fri May 21 10:07:21 2021 +0200

    Fix for Java16+
    
    The commit fa5e40dc59355163d89cd904fcf4c4724ba3d3d6
    made build fail on Java16 due illegal reflective access.
    
    The commit is wrong that is uses "aop" guice, that is
    the culprit of illegal reflective access (on Java11
    generates a warning on system out, but Java16
    prevents it).
    
    Solution: use the "no_aop" guice instead. Also,
    there was a SLF4J warning about non existence of
    backend in tests, fixed by adding simple backend
    with test scope.
---
 pom.xml | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/pom.xml b/pom.xml
index c428afb..a043736 100644
--- a/pom.xml
+++ b/pom.xml
@@ -107,6 +107,7 @@
         <groupId>org.sonatype.sisu</groupId>
         <artifactId>sisu-guice</artifactId>
         <version>3.2.6</version>
+        <classifier>no_aop</classifier>
       </dependency>
     </dependencies>
   </dependencyManagement>
@@ -228,6 +229,7 @@
     <dependency>
       <groupId>org.sonatype.sisu</groupId>
       <artifactId>sisu-guice</artifactId>
+      <classifier>no_aop</classifier>
       <scope>test</scope>
     </dependency>
     <dependency>
@@ -254,6 +256,12 @@
       <version>2.28.2</version>
       <scope>test</scope>
     </dependency>
+    <dependency>
+      <groupId>org.slf4j</groupId>
+      <artifactId>slf4j-simple</artifactId>
+      <version>1.7.30</version>
+      <scope>test</scope>
+    </dependency>
   </dependencies>
 
   <build>